Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39EDBD9FA for ; Tue, 25 Dec 2012 13:06:10 +0000 (UTC) Received: (qmail 86355 invoked by uid 500); 25 Dec 2012 13:06:09 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 86316 invoked by uid 500); 25 Dec 2012 13:06:09 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 86301 invoked by uid 99); 25 Dec 2012 13:06:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Dec 2012 13:06:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 693861C4B73; Tue, 25 Dec 2012 13:06:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7903301836857093212==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-648 From: "Gavin Lee" To: "Gavin Lee" Cc: "cloudstack" , "Isaac Chiang" Date: Tue, 25 Dec 2012 13:06:04 -0000 Message-ID: <20121225130604.22400.3025@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gavin Lee" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8637/ X-Sender: "Gavin Lee" References: <20121225130428.22399.16411@reviews.apache.org> In-Reply-To: <20121225130428.22399.16411@reviews.apache.org> Reply-To: "Gavin Lee" --===============7903301836857093212== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Dec. 25, 2012, 1:04 p.m., Gavin Lee wrote: > > Ship It! Hi, Isaac Thank for this patch & sorry for my late reply. Please close as submitted. - Gavin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/#review14889 ----------------------------------------------------------- On Dec. 18, 2012, 2:16 a.m., Isaac Chiang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8637/ > ----------------------------------------------------------- > = > (Updated Dec. 18, 2012, 2:16 a.m.) > = > = > Review request for cloudstack and Gavin Lee. > = > = > Description > ------- > = > This patch is to fix the CLOUDSTACK-436 issue described in https://issues= .apache.org/jira/browse/CLOUDSTACK-648. > = > = > Diffs > ----- > = > api/src/com/cloud/api/response/UserResponse.java 920eb59 = > client/tomcatconf/commands.properties.in 149547e = > server/src/com/cloud/api/ApiDBUtils.java 3b5f634 = > server/src/com/cloud/api/ApiResponseHelper.java ebe8415 = > ui/scripts/accounts.js 324c5f5 = > ui/scripts/sharedFunctions.js f1b7efa = > = > Diff: https://reviews.apache.org/r/8637/diff/ > = > = > Testing > ------- > = > 1. A CloudStack normal user can modify its own password. > 2. Domain admin can change it's domain user's password, including subdoma= in admins and subdomain users. > 3. In the same domain, a domain admin cannot update cannot modify another= domain admin's password. > = > = > Thanks, > = > Isaac Chiang > = > --===============7903301836857093212==--