Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A068DE16 for ; Mon, 24 Dec 2012 03:04:38 +0000 (UTC) Received: (qmail 17954 invoked by uid 500); 24 Dec 2012 03:04:37 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 17753 invoked by uid 500); 24 Dec 2012 03:04:36 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 17730 invoked by uid 99); 24 Dec 2012 03:04:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Dec 2012 03:04:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CC04C1C5E5C; Mon, 24 Dec 2012 03:04:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1822254469065343894==" MIME-Version: 1.0 Subject: Re: Review Request: Change to avoid NPE and throw a proper exception if the network is not found From: "Rohit Yadav" To: "cloudstack" , "Devdeep Singh" , "Rohit Yadav" Date: Mon, 24 Dec 2012 03:04:30 -0000 Message-ID: <20121224030430.22400.82279@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7341/ X-Sender: "Rohit Yadav" References: <20120928135552.18992.98393@reviews.apache.org> In-Reply-To: <20120928135552.18992.98393@reviews.apache.org> Reply-To: "Rohit Yadav" --===============1822254469065343894== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7341/#review14878 ----------------------------------------------------------- Ship it! Applied on master: commit 8f6fdc3efc37a2e97d1b745e9109e1fc85a990f4 Author: Devdeep Singh Date: Sun Dec 23 19:03:03 2012 -0800 CLOUDSTACK-227: Fix NPE and throw an exception if the network is not fo= und in Xen = Signed-off-by: Rohit Yadav - Rohit Yadav On Sept. 28, 2012, 1:55 p.m., Devdeep Singh wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7341/ > ----------------------------------------------------------- > = > (Updated Sept. 28, 2012, 1:55 p.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > Made a change to avoid NPE and throw a proper exception if the storage ne= twork is not found. > = > = > This addresses bug 227. > = > = > Diffs > ----- > = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixRes= ourceBase.java d2db85c = > = > Diff: https://reviews.apache.org/r/7341/diff/ > = > = > Testing > ------- > = > Created a zone with an invalid network name for storage and checked the l= ogs for the exception thrown. > = > = > Thanks, > = > Devdeep Singh > = > --===============1822254469065343894==--