Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88196D533 for ; Thu, 20 Dec 2012 09:54:29 +0000 (UTC) Received: (qmail 81602 invoked by uid 500); 20 Dec 2012 09:54:28 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 81561 invoked by uid 500); 20 Dec 2012 09:54:28 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 81524 invoked by uid 99); 20 Dec 2012 09:54:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2012 09:54:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4B3221C5B2F; Thu, 20 Dec 2012 09:54:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1041252164838227082==" MIME-Version: 1.0 Subject: Re: Review Request: ACL: use the securityChecker for now for the doamin access check for createUSerCmd From: "Rohit Yadav" To: "Rohit Yadav" Cc: "cloudstack" , "Fang Wang" Date: Thu, 20 Dec 2012 09:54:22 -0000 Message-ID: <20121220095422.380.43304@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8691/ X-Sender: "Rohit Yadav" References: <20121220004151.380.53509@reviews.apache.org> In-Reply-To: <20121220004151.380.53509@reviews.apache.org> Reply-To: "Rohit Yadav" --===============1041252164838227082== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8691/#review14754 ----------------------------------------------------------- Holding review on this one, we may have multiple adapters this patch assume= s only one adapter and not a list and we have to change interface to accept= method(s) instead of strings. - Rohit Yadav On Dec. 20, 2012, 12:41 a.m., Fang Wang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8691/ > ----------------------------------------------------------- > = > (Updated Dec. 20, 2012, 12:41 a.m.) > = > = > Review request for cloudstack and Rohit Yadav. > = > = > Description > ------- > = > Do the domain access check on createUserCmd. = > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java= a1461fb = > server/src/com/cloud/api/ApiDispatcher.java e75a15c = > server/src/com/cloud/user/AccountManagerImpl.java 593d295 = > = > Diff: https://reviews.apache.org/r/8691/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Fang Wang > = > --===============1041252164838227082==--