Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA286E223 for ; Fri, 14 Dec 2012 03:30:44 +0000 (UTC) Received: (qmail 38613 invoked by uid 500); 14 Dec 2012 03:30:44 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 38550 invoked by uid 500); 14 Dec 2012 03:30:44 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 38511 invoked by uid 99); 14 Dec 2012 03:30:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2012 03:30:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 45F8A1C562D; Fri, 14 Dec 2012 03:30:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4709030397143815145==" MIME-Version: 1.0 Subject: Review Request: API refactoring -- add the entityType handling in apiDispatcher From: "Fang Wang" To: "Rohit Yadav" Cc: "cloudstack" , "Fang Wang" Date: Fri, 14 Dec 2012 03:30:38 -0000 Message-ID: <20121214033038.7729.83941@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Fang Wang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8578/ X-Sender: "Fang Wang" Reply-To: "Fang Wang" --===============4709030397143815145== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8578/ ----------------------------------------------------------- Review request for cloudstack and Rohit Yadav. Description ------- Add the entity handling in apiDisptacher; in genericDao, add findByXid(); This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-518. Diffs ----- api/src/org/apache/cloudstack/api/response/DomainResponse.java e97653b = api/src/org/apache/cloudstack/api/response/UserVmResponse.java 4934d8b = server/src/com/cloud/api/ApiDispatcher.java 37321a1 = server/src/com/cloud/api/ApiServer.java 183249f = server/src/com/cloud/dao/EntityManagerImpl.java 1430c08 = utils/src/com/cloud/utils/db/GenericDao.java f36c4d8 = utils/src/com/cloud/utils/db/GenericDaoBase.java be0fe89 = Diff: https://reviews.apache.org/r/8578/diff/ Testing ------- Thanks, Fang Wang --===============4709030397143815145==--