Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F0292D8B6 for ; Tue, 11 Dec 2012 22:31:29 +0000 (UTC) Received: (qmail 59905 invoked by uid 500); 11 Dec 2012 22:31:29 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 59803 invoked by uid 500); 11 Dec 2012 22:31:29 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 59792 invoked by uid 99); 11 Dec 2012 22:31:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2012 22:31:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0A81F1C5546; Tue, 11 Dec 2012 22:31:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5890364927774401746==" MIME-Version: 1.0 Subject: Review Request: Allow for custom storage adaptors based on pool type in KVM From: "Marcus Sorensen" To: "edison su" Cc: "Marcus Sorensen" , "cloudstack" Date: Tue, 11 Dec 2012 22:31:25 -0000 Message-ID: <20121211223125.7729.88192@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Marcus Sorensen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8534/ X-Sender: "Marcus Sorensen" Reply-To: "Marcus Sorensen" --===============5890364927774401746== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8534/ ----------------------------------------------------------- Review request for cloudstack and edison su. Description ------- This is a refactor of a few things to allow pluggable storage adaptors for = KVM. Instead of using LibvirtStorageAdaptor for everything, you can create = your own storage adaptor and use it. We select storage adaptor based on sto= rage pool type, thus we needed to adjust LibvirtComputingResource to pass p= ool type to everything in KVMStoragePoolManager. This in turn required that= we pass the info necessary to LibvirtComputingResource as well, so a few a= gent Commands were modified. Note this patch in and of itself shouldn't change any existing behavior, ju= st allow for new storage adaptors to be selected based on storage pool type. Diffs ----- api/src/com/cloud/agent/api/BackupSnapshotCommand.java 9476d7d = api/src/com/cloud/agent/api/CreatePrivateTemplateFromSnapshotCommand.java= bf6f260 = api/src/com/cloud/agent/api/CreatePrivateTemplateFromVolumeCommand.java b= 589ed5 = api/src/com/cloud/agent/api/CreateVolumeFromSnapshotCommand.java f006329 = api/src/com/cloud/agent/api/SnapshotCommand.java 892db37 = api/src/com/cloud/agent/api/UpgradeSnapshotCommand.java e451768 = api/src/com/cloud/agent/api/downloadSnapshotFromSwiftCommand.java 0586f8c = api/src/com/cloud/agent/api/storage/PrimaryStorageDownloadCommand.java b5= 63177 = plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComp= utingResource.java e0187e6 = plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePo= olManager.java 2c0e0ac = server/src/com/cloud/storage/StorageManagerImpl.java e252633 = server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 32e37e6 = server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2 = server/src/com/cloud/vm/UserVmManagerImpl.java 02d630f = Diff: https://reviews.apache.org/r/8534/diff/ Testing ------- tested the following on a KVM cloudstack install: add primary storage delete primary storage add vm to CLVM primary storage add vm to NFS primary storage create data disk create snapshot create template attach datadisk to VM detach datadisk from VM delete datadisk delete template delete snapshot stop vm delete vm register iso attach iso detach iso Thanks, Marcus Sorensen --===============5890364927774401746==--