Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3484417910336127161=="
MIME-Version: 1.0
Subject: Review Request: CLOUDSTACK-605: Host physical CPU is incorrectly
 calculated
 for Vmware hosts
From: "Koushik Das" <koushik.das@citrix.com>
To: "Kelven Yang" <kelven.yang@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Koushik Das" <koushik.das@citrix.com>
Date: Tue, 11 Dec 2012 13:11:09 -0000
Message-ID: <20121211131109.7729.39501@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Koushik Das" <noreply@reviews.apache.org>
Reply-To: "Koushik Das" <koushik.das@citrix.com>

--===============3484417910336127161==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8511/
-----------------------------------------------------------

Review request for cloudstack and Kelven Yang.


Description
-------

There is a mismatch in host CPU count displayed in CS UI (displayed under t=
he 'Statistics' tab when a host is selected) compared to that in vCenter. T=
he mismatch happens for ESX hosts having > 1 cpu package. This will affect =
VM allocation logic.
 =

Currently host CPU is computed based on below logic (HostHardwareSummary is=
 defined in Vmware library)
 =

HostHardwareSummary hardwareSummary =3D getHostHardwareSummary(); =

summary.setCpuCount(hardwareSummary.getNumCpuCores()*hardwareSummary.getNum=
CpuPkgs());
 =

The correct logic is to use hardwareSummary.getNumCpuCores() only. =


This addresses bug CLOUDSTACK-605.


Diffs
-----

  vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 3557048 =


Diff: https://reviews.apache.org/r/8511/diff/


Testing
-------

Verified on esx hosts with 1 and 2 CPU packages.


Thanks,

Koushik Das


--===============3484417910336127161==--