Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AD55DB68 for ; Mon, 10 Dec 2012 19:29:48 +0000 (UTC) Received: (qmail 66290 invoked by uid 500); 10 Dec 2012 19:29:47 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 66182 invoked by uid 500); 10 Dec 2012 19:29:47 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 66169 invoked by uid 99); 10 Dec 2012 19:29:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Dec 2012 19:29:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2755D1C5433; Mon, 10 Dec 2012 19:29:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6040158236599747439==" MIME-Version: 1.0 Subject: Re: Review Request: Clean up some view VO code to remove code duplication. From: "Rohit Yadav" To: "Rohit Yadav" Cc: "cloudstack" , "Min Chen" Date: Mon, 10 Dec 2012 19:29:43 -0000 Message-ID: <20121210192943.7759.668@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8444/ X-Sender: "Rohit Yadav" References: <20121210192658.7729.80244@reviews.apache.org> In-Reply-To: <20121210192658.7729.80244@reviews.apache.org> Reply-To: "Rohit Yadav" --===============6040158236599747439== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8444/#review14255 ----------------------------------------------------------- Ship it! Awesome! - Rohit Yadav On Dec. 10, 2012, 7:26 p.m., Min Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8444/ > ----------------------------------------------------------- > = > (Updated Dec. 10, 2012, 7:26 p.m.) > = > = > Review request for cloudstack and Rohit Yadav. > = > = > Description > ------- > = > Create Base Db view VO class to have some common view VO code. > = > = > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/view/vo/BaseViewVO.java PRE-CREATION = > api/src/org/apache/cloudstack/api/view/vo/DomainRouterJoinVO.java 747cd= e5 = > api/src/org/apache/cloudstack/api/view/vo/EventJoinVO.java da322fb = > api/src/org/apache/cloudstack/api/view/vo/ResourceTagJoinVO.java e39c11= 5 = > api/src/org/apache/cloudstack/api/view/vo/SecurityGroupJoinVO.java 725e= e90 = > api/src/org/apache/cloudstack/api/view/vo/UserVmJoinVO.java aff2a1b = > = > Diff: https://reviews.apache.org/r/8444/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Min Chen > = > --===============6040158236599747439==--