cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: Change to avoid NPE and throw a proper exception if the network is not found
Date Mon, 24 Dec 2012 03:04:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7341/#review14878
-----------------------------------------------------------

Ship it!


Applied on master:

commit 8f6fdc3efc37a2e97d1b745e9109e1fc85a990f4
Author: Devdeep Singh <devdeep.singh@citrix.com>
Date:   Sun Dec 23 19:03:03 2012 -0800

    CLOUDSTACK-227: Fix NPE and throw an exception if the network is not found in Xen
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>

- Rohit Yadav


On Sept. 28, 2012, 1:55 p.m., Devdeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7341/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 1:55 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Made a change to avoid NPE and throw a proper exception if the storage network is not
found.
> 
> 
> This addresses bug 227.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
d2db85c 
> 
> Diff: https://reviews.apache.org/r/7341/diff/
> 
> 
> Testing
> -------
> 
> Created a zone with an invalid network name for storage and checked the logs for the
exception thrown.
> 
> 
> Thanks,
> 
> Devdeep Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message