cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: fixing a regression for network.conf file
Date Mon, 17 Dec 2012 21:21:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8651/#review14612
-----------------------------------------------------------

Ship it!


Thanks for the patch. Ammended the commit message as per discussed format on ML (hope it's
okay with you).
For giving reference to a commit on commit message header line (summary line), referencing
works with using just the first 10 chars instead of full SHA.
This saves us from writing long commit summary lines.

Applied on master.

commit 7c56a81bddf4eeefe8989864f2c48a7dbb484297
Author: James Martin <jmartin@basho.com>
Date:   Mon Dec 17 15:52:15 2012 -0500

    devcloud: Fixed regression for network.conf commit 97fe053e2e
    
    Fixes regression for network.conf, commit:
    commit 97fe053e2e1c3fbaf891f300809fa0b926a0ea89
    Author: Chip Childers <chip.childers@gmail.com>
    Date: Mon Aug 13 11:12:01 2012 -0400
    
    Removed ASF license header from network.conf, because XCP doesn't respect comment lines
in this file
    
    This seemed to have been re-introduced during the merge in of my patch.  This file has
no been removed
    completely and is created in-line through the puppet module.

- Rohit Yadav


On Dec. 17, 2012, 9:04 p.m., James Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8651/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2012, 9:04 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> Fixed the following regression for network.conf commit
>  97fe053e2e1c3fbaf891f300809fa0b926a0ea89 Author: Chip
>  Childers <chip.childers@gmail.com> Date:   Mon Aug 13
>  11:12:01 2012 -0400
> 
>     Removed ASF license header from network.conf, because XCP doesn't respect comment
lines in this file
> 
> This seemed to have been re-introduced during the merge in of my patch.  This file has
now been removed
> completely and is created in-line through the puppet module.
> 
> 
> Diffs
> -----
> 
>   tools/devcloud/src/deps/boxes/xenbox-build/puppet/modules/devcloudinitial/files/network.conf
91dd743 
>   tools/devcloud/src/deps/boxes/xenbox-build/puppet/modules/devcloudinitial/manifests/init.pp
ee58a71 
> 
> Diff: https://reviews.apache.org/r/8651/diff/
> 
> 
> Testing
> -------
> 
> boxer.sh -b xenbox
> 
> 
> Thanks,
> 
> James Martin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message