cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-643: KVM snapshots deleted via API not deleted from physical secondary storage
Date Mon, 17 Dec 2012 04:15:42 GMT


> On Dec. 16, 2012, 1:09 p.m., Nitin Mehta wrote:
> > I guess we need to take care of migration as well. For KVM if its marked removed
in DB we need to check if its deleted from secondary storage as well.

Storage gc that runs regularly will identify the outdated snapshots and delete them. So an
upgrade/migration script wouldn't be necessary. See the correction to the GC in review: https://reviews.apache.org/r/8632/


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8613/#review14554
-----------------------------------------------------------


On Dec. 15, 2012, 3:22 a.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8613/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 3:22 a.m.)
> 
> 
> Review request for cloudstack, edison su and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> KVM snapshot command objects return absolute path to their qcow2
> backups while the SSVM responsible for the snapshot deletion builds a
> path from the tenant's associated path. This causes a quiet failure
> resulting in a successful answer back to management server while the
> image still persists on sec. storage.
> 
> Cmd object sent by management server:
> 
> {
>     Cmd,
>     MgmtId: 345050870294,
>     via: 11,
>     Ver: v1,
>     Flags: 100011,
>     [
>         {
>             "DeleteSnapshotBackupCommand": {
>                 "all": false,
>                 "snapshotUuid": "/snapshots/3/7/31/any_ROOT-29_20121214210220",
>                 "secondaryStorageUrl": "nfs://secstorage/export/home/storage/secondary",
>                 "dcId": 3,
>                 "accountId": 7,
>                 "volumeId": 31,
>                 "wait": 0
>             }
>         }
>     ]
> }
> 
> Path interpreted by CS:
> secondaryStorageUrl + dcId + accountId + volumeId + snapshotUuid
> = nfs://secstorage/export/home/storage/secondary/3/7/31/snapshots/3/7/31/any_ROOT-29_20121214210220
> 
> While it should be
> = nfs://secstorage/export/home/storage/secondary/snapshots/3/7/31/any_ROOT-29_20121214210220
> 
> 
> This addresses bug cloudstack-643.
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 3d6356e 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java d8fdc3a 
> 
> Diff: https://reviews.apache.org/r/8613/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message