Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: 
 <B1DF26ECC0458748AC97CECE2DA98D41012FA1E1C4F7@SJCPMAILBOX01.citrite.net>
References: 
 <CAMqugTH5BdcHksf+obx_2_eGszA0Pzg+NkcOEoapbd+RJFP_vg@mail.gmail.com>
	<6DE00C9FDF08A34683DF71786C70EBF02F3811A1@SBPOMB402.sbp.lan>
	<B1DF26ECC0458748AC97CECE2DA98D41012FA1952A13@SJCPMAILBOX01.citrite.net>
	<c74643eb59e465fc62796d679c697438@mail.gmail.com>
	<CAMqugTEOEODRBDJsLADcMAuSvvL4+c0d5raU_jj8=9xVa_uHog@mail.gmail.com>
	<CA+96GG7H+gxskVvSda_oSmyBodjkJZ6gHAfhOUE_+Uz4Ch5REg@mail.gmail.com>
	<B1DF26ECC0458748AC97CECE2DA98D41012FA1E1C4E3@SJCPMAILBOX01.citrite.net>
	<CA+96GG6bUaApK5GQXkhzm9kRj42H-SrY205wieX-S=BCCe0Lyw@mail.gmail.com>
	<B1DF26ECC0458748AC97CECE2DA98D41012FA1E1C4F7@SJCPMAILBOX01.citrite.net>
Date: Fri, 9 Nov 2012 14:56:23 -0500
Message-ID: 
 <CA+96GG4BtUBPAX9D=FgdBHxSnx=YukbdGG7qboSW2tXCUXVwmg@mail.gmail.com>
Subject: Re: Unit tests
From: Chip Childers <chip.childers@sungard.com>
To: cloudstack-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Nov 9, 2012 at 2:46 PM, Alex Huang <Alex.Huang@citrix.com> wrote:
>>
>> 1 - Do we want tests to run each time mvn install is run?
>
> No.  I like to have choices.
>
>>
>> 2 - Do we want to get stricter about what exactly is considered to be
>> a unit test (vs an automated test that may or may not be based on the
>> junit framework)?
>
> I actually consider db tests to be unit tests as long as the db is setup and cleaned up by the unit test itself.

Having a real DB as a requirement for low level unit tests does two
things that I don't like.

First, it requires the configuration of a database (in our case,
MySQL) as part of running the test.  That's a build dependency that
(IMO) shouldn't be needed.

Second, configuring and using a real database significantly slows down
the unit test process.  For unit tests to be useful, they have to be
as fast as possible.  We simply don't have enough unit tests for this
to be a major problem right now, but as the coverage increases (true
unit tests, not integration tests) this will get much worse.

In my ideal world, unit tests are limited in their test scope to only
cover code within a particular object (inherited or directly
accessed).  Imported objects should usually be mocked.  We might be
arguing about nuance of definition here, but I've always tried to keep
a bright red line between unit and integration tests.  Both matter,
but they test different things.

> I think anything that requires starting of jetty is definitely not a unit test.

Completely agree with this one.

> --Alex
>