cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Min Chen <>
Subject Re: Review Request: List API performance optimization part I.
Date Thu, 22 Nov 2012 03:20:28 GMT
That is a good idea for such API refactoring efforts mentioned in
toring, since these work will touch every API, not just list API since it
involves refactoring all Response objects to remove IdentityMapper and
thus other create/operational apis will be impacted as well. I don't know
if we have already a suite of test cases to test API regressions. Sudha,
any ideas from QA side?


On 11/21/12 5:29 PM, "David Nalley" <> wrote:

>>> On Nov. 22, 2012, 12:05 a.m., Chiradeep Vittal wrote:
>>> > server/src/com/cloud/vm/, line 3006
>>> > 
>>> >
>>> >     this is a major piece of surgery on this method. How are you
>>>sure that the before and after results are identical?
>> I have done a prototype before this checkin and verified that it
>>returns the same result as before. UserVmJoinVO is view object
>>containing all the fields before in UserVm interface, no information is
>Perhaps we should have tests that establish existing present
>functionality, and then have those in place before this surgery is
>performed which could then assure us that the functionality is

View raw message