cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Min Chen" <min.c...@citrix.com>
Subject Re: Review Request: List API performance optimization part I.
Date Mon, 26 Nov 2012 19:53:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8172/
-----------------------------------------------------------

(Updated Nov. 26, 2012, 7:53 p.m.)


Review request for cloudstack and Prachi Damle.


Changes
-------

Addressed two comments in the new patch:
1) Rename IControlledViewEntity interface name to ControlledViewEntity
2) Rename all zone related field names to dataCenter prefixed names based on CloudStack convention.


Description
-------

This is part 1 of list API refactoring.
Commands covered: listVmsCmd, listRoutersCmd
Response covered: UserVmResponse, DomainRouterResponse.
DB views created: user_vm_view, domain_router_view.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.


Diffs (updated)
-----

  api/src/com/cloud/api/ResponseGenerator.java 996a5fc 
  api/src/com/cloud/api/ResponseObject.java 2d08fb9 
  api/src/com/cloud/api/commands/ListRoutersCmd.java 8bf9ba8 
  api/src/com/cloud/api/commands/ListVMsCmd.java 2f6f988 
  api/src/com/cloud/api/response/BaseResponse.java e343a10 
  api/src/com/cloud/api/response/DomainRouterResponse.java d710aad 
  api/src/com/cloud/api/response/IControlledViewEntityResponse.java PRE-CREATION 
  api/src/com/cloud/api/response/NicResponse.java 69d5c31 
  api/src/com/cloud/api/response/UserVmResponse.java f74c072 
  api/src/com/cloud/api/view/vo/ControlledViewEntity.java PRE-CREATION 
  api/src/com/cloud/api/view/vo/DomainRouterJoinVO.java PRE-CREATION 
  api/src/com/cloud/api/view/vo/UserVmJoinVO.java PRE-CREATION 
  api/src/com/cloud/server/ManagementService.java 7532cae 
  api/src/com/cloud/vm/UserVmService.java 02682b0 
  server/src/com/cloud/api/ApiDBUtils.java 418fe362 
  server/src/com/cloud/api/ApiResponseHelper.java caabd71 
  server/src/com/cloud/api/ApiServer.java a5c9ea5 
  server/src/com/cloud/api/response/ApiResponseSerializer.java dc15763 
  server/src/com/cloud/configuration/DefaultComponentLibrary.java 4edd402 
  server/src/com/cloud/server/ManagementServerImpl.java 117be57 
  server/src/com/cloud/user/AccountManager.java 90a34ad 
  server/src/com/cloud/user/AccountManagerImpl.java 0def008 
  server/src/com/cloud/vm/UserVmManager.java 4ce9bfe 
  server/src/com/cloud/vm/UserVmManagerImpl.java a2a548f 
  server/src/com/cloud/vm/dao/DomainRouterJoinDao.java PRE-CREATION 
  server/src/com/cloud/vm/dao/DomainRouterJoinDaoImpl.java PRE-CREATION 
  server/src/com/cloud/vm/dao/UserVmJoinDao.java PRE-CREATION 
  server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java PRE-CREATION 
  server/test/com/cloud/api/APITest.java PRE-CREATION 
  server/test/com/cloud/api/ListPerfTest.java PRE-CREATION 
  server/test/com/cloud/api/LoginResponse.java PRE-CREATION 
  server/test/com/cloud/keystore/KeystoreTest.java e0e2126 
  server/test/com/cloud/user/MockAccountManagerImpl.java 08234fd 
  server/test/com/cloud/vm/MockUserVmManagerImpl.java 35ee139 
  setup/db/create-schema.sql acbbc41 
  utils/src/com/cloud/utils/db/GenericDaoBase.java 8d5cb96 

Diff: https://reviews.apache.org/r/8172/diff/


Testing
-------

Create a performance unit test class to test the performance time.


Thanks,

Min Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message