Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5121BDA32 for ; Tue, 23 Oct 2012 10:34:23 +0000 (UTC) Received: (qmail 58330 invoked by uid 500); 23 Oct 2012 10:34:23 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 58175 invoked by uid 500); 23 Oct 2012 10:34:22 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 58159 invoked by uid 99); 23 Oct 2012 10:34:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Oct 2012 10:34:22 +0000 X-ASF-Spam-Status: No, hits=1.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL,TO_NO_BRKTS_MSFT X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [74.125.149.18] (HELO na3sys009aog137.obsmtp.com) (74.125.149.18) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Oct 2012 10:34:15 +0000 Received: from mail-gg0-f197.google.com ([209.85.161.197]) (using TLSv1) by na3sys009aob137.postini.com ([74.125.148.12]) with SMTP ID DSNKUIZykQC+pltlYOHdK+6Dk3IqZnL2v0kN@postini.com; Tue, 23 Oct 2012 03:33:54 PDT Received: by mail-gg0-f197.google.com with SMTP id y3so6623111ggc.0 for ; Tue, 23 Oct 2012 03:33:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:references:in-reply-to:mime-version:x-mailer:thread-index:date :message-id:subject:to:content-type:x-gm-message-state; bh=QUyQpADAyTMq5VFCOnfbB7GpzW0UeFAntFqZj5KKeAg=; b=a5f0b/p5ux+GkHE9AU9NamSCwGQnNm4G8NFrnue9lFl7hLf+YrD3U5VxrVarUOIFJu j3rO9Pp0/YIGJvU/vFS05uvLFdWCCmB5Ee8V0eMlnhi4MBKJokIZgRZnWwgnw0rvBabn t2GB/PUJwkTzJSB+XpMgQIc8waYcN3U444z8L4WCU3TXQm3i9JdaPiCi2rFIZm7iMlsF BYa3YcPjvEeT2Glu1h6J5YKrmIrcLWbaZ191QWQJyvXCZXk2pnLtFc/Dc3S9VeMDlX/u xrO4a4NHged7alvWusN/W12C1x3wemZsv0+xJBvYTCqR6qR8UZebV03qjoGf50rIIkJa 2cYg== Received: by 10.229.202.204 with SMTP id ff12mr1340417qcb.156.1350988432784; Tue, 23 Oct 2012 03:33:52 -0700 (PDT) Received: by 10.229.202.204 with SMTP id ff12mr1340415qcb.156.1350988432619; Tue, 23 Oct 2012 03:33:52 -0700 (PDT) From: Manikanta Kattamuri References: <20121003202141.22633.25292@reviews.apache.org> <20121003203918.22633.50039@reviews.apache.org> In-Reply-To: <20121003203918.22633.50039@reviews.apache.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQK+wphQYHK6Bwl0lEymHJzxL7hn2AE8Dp/VldqtgJA= Date: Tue, 23 Oct 2012 16:03:51 +0530 Message-ID: <70e6ee5e4e5e64de51e64ddb991876e4@mail.gmail.com> Subject: RE: Review Request: Another batch of unit tests for the api project To: cloudstack-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlz63U+nHNOd06NNv2I3/FBke3dO/KsnhpFXTGecAH2qD26DPYLFxGlejWHIZqsR6L6O1scq28TO0bltaUbO0BneiEWOAAilnjJ77F3a6mAp3EcP28omqWzbN6OsnB9tB9X2aZgyZSHfQZq/1xwQ/j5rUO1HMLpRxx7dmW4B4kK6we233yWfHjdDScJCQ5pzsQdl2Re X-Virus-Checked: Checked by ClamAV on apache.org Can anyone review this and close it, I feel the present unittest folder structure is not testable and is orthodox to maven policies as it is defined as an independent project inside api project. Manikanta. -----Original Message----- From: Yichi Lu [mailto:noreply@reviews.apache.org] On Behalf Of Yichi Lu Sent: Thursday, October 04, 2012 2:09 AM To: cloudstack; Yichi Lu Subject: Re: Review Request: Another batch of unit tests for the api project ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7427/ ----------------------------------------------------------- (Updated Oct. 3, 2012, 8:39 p.m.) Review request for cloudstack. Changes ------- uploaded two patch files. Description ------- another batch of junit tests for the api project. Also changed test directory from api/unittest to api/src/test. Diffs (updated) ----- api/src/test/.gitignore PRE-CREATION api/src/test/java/com/cloud/agent/api/.gitignore PRE-CREATION api/src/test/java/com/cloud/agent/api/AgentControlAnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/AgentControlCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/AnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/AttachIsoCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/AttachVolumeAnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/AttachVolumeCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/BackupSnapshotAnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/BumpUpPriorityCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CancelCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/ChangeAgentAnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/ChangeAgentCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CheckHealthAnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CheckHealthCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CheckNetworkAnswerTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CheckNetworkCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CheckOnHostCommandTest.java PRE-CREATION api/src/test/java/com/cloud/agent/api/CheckOnHostCommandTest.java 8960aa0 api/src/test/java/com/cloud/agent/api/SnapshotCommandTest.java PRE-CREATION api/src/test/pom.xml PRE-CREATION api/unittest/.gitignore eb5a316 api/unittest/pom.xml 8774191 api/unittest/src/com/cloud/agent/api/.gitignore 991a3b6 api/unittest/src/com/cloud/agent/api/AgentControlAnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AgentControlAnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AgentControlAnswerTest.java 7bfd776 api/unittest/src/com/cloud/agent/api/AgentControlCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AgentControlCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AgentControlCommandTest.java 12ea0d6 api/unittest/src/com/cloud/agent/api/AnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AnswerTest.java c53c84a api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java 638ae29 api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java 638ae29 api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java 42df9db api/unittest/src/com/cloud/agent/api/AttachVolumeAnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AttachVolumeAnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AttachVolumeAnswerTest.java 886995e api/unittest/src/com/cloud/agent/api/AttachVolumeCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AttachVolumeCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/AttachVolumeCommandTest.java 24e1a51 api/unittest/src/com/cloud/agent/api/BackupSnapshotAnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/BackupSnapshotAnswerTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/BackupSnapshotAnswerTest.java 6c6929f api/unittest/src/com/cloud/agent/api/BackupSnapshotCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/BackupSnapshotCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/BackupSnapshotCommandTest.java 3328440 api/unittest/src/com/cloud/agent/api/SnapshotCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/SnapshotCommandTest.java PRE-CREATION api/unittest/src/com/cloud/agent/api/SnapshotCommandTest.java 5bb412e Diff: https://reviews.apache.org/r/7427/diff/ Testing ------- USLT-205731:junit-tests yichi.lu$ cd api/src/test USLT-205731:test yichi.lu$ mvn test [INFO] Scanning for projects... [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Apache CloudStack API Unittest 4.0.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-api-test --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /Users/yichi.lu/CloudStack/junit-tests/api/src/test/src/main/resources [INFO] [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ cloud-api-test --- [INFO] Compiling 221 source files to /Users/yichi.lu/CloudStack/junit-tests/api/src/test/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-api-test --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /Users/yichi.lu/CloudStack/junit-tests/api/src/test/target/test-classes [INFO] [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ cloud-api-test --- [INFO] Compiling 18 source files to /Users/yichi.lu/CloudStack/junit-tests/api/src/test/java/com/cloud/agent/api [INFO] [INFO] --- maven-surefire-plugin:2.10:test (default-test) @ cloud-api-test --- [INFO] Surefire report directory: /Users/yichi.lu/CloudStack/junit-tests/api/src/test/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running com.cloud.agent.api.AgentControlAnswerTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 sec Running com.cloud.agent.api.AgentControlCommandTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.AnswerTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running com.cloud.agent.api.AttachIsoCommandTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec Running com.cloud.agent.api.AttachVolumeAnswerTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.AttachVolumeCommandTest Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.BackupSnapshotAnswerTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.BackupSnapshotCommandTest Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec Running com.cloud.agent.api.BumpUpPriorityCommandTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running com.cloud.agent.api.CancelCommandTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.ChangeAgentAnswerTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.ChangeAgentCommandTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.CheckHealthAnswerTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running com.cloud.agent.api.CheckHealthCommandTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec Running com.cloud.agent.api.CheckNetworkAnswerTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec Running com.cloud.agent.api.CheckNetworkCommandTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running com.cloud.agent.api.CheckOnHostCommandTest Tests run: 41, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec Running com.cloud.agent.api.SnapshotCommandTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Results : Tests run: 116, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 5.784s [INFO] Finished at: Wed Oct 03 15:16:48 CDT 2012 [INFO] Final Memory: 12M/554M [INFO] ------------------------------------------------------------------------ Thanks, Yichi Lu