cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Huang" <alex.hu...@citrix.com>
Subject Re: Review Request: Handle self-managed db connection correctly
Date Thu, 25 Oct 2012 18:36:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7726/#review12784
-----------------------------------------------------------


The string construction should be inside the isDebugEnabled() check.  The whole point is to
avoid expensive gc on String objects so if the string construction is outside of the check,
then it's useless.

license should be added to all the new test files.

Nicely done.  I'll commit once the above two are addressed.

- Alex Huang


On Oct. 25, 2012, 6:26 p.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7726/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 6:26 p.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Description
> -------
> 
> This patch is to fix this bug https://issues.apache.org/jira/browse/CLOUDSTACK-409
> 
> 
> This addresses bug CLOUDSTACK-409.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiServlet.java 8a1d4de 
>   server/src/com/cloud/cluster/ClusterManagerImpl.java 4dbb16c 
>   utils/src/com/cloud/utils/db/Transaction.java bcf7ae1 
>   utils/test/com/cloud/utils/db/DbTestDao.java PRE-CREATION 
>   utils/test/com/cloud/utils/db/DbTestVO.java PRE-CREATION 
>   utils/test/com/cloud/utils/db/TransactionTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7726/diff/
> 
> 
> Testing
> -------
> 
> Testing is done locally.
> 
> 
> Thanks,
> 
> Min Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message