Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 829DADDEB for ; Tue, 18 Sep 2012 12:51:29 +0000 (UTC) Received: (qmail 81973 invoked by uid 500); 18 Sep 2012 12:51:28 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 81819 invoked by uid 500); 18 Sep 2012 12:51:27 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 81797 invoked by uid 99); 18 Sep 2012 12:51:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 12:51:26 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.216.175] (HELO mail-qc0-f175.google.com) (209.85.216.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 12:51:20 +0000 Received: by qcad10 with SMTP id d10so5711677qca.6 for ; Tue, 18 Sep 2012 05:50:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding:x-gm-message-state; bh=sW9XxgRxjI6ZZAiJ+9axCS73cicrTNLtOeUuyI6vhtE=; b=K/DBVubkXLioDOjqqtp9JD25zzt1Iu7MnsijmAu72Uq7aOHB+3GZ/wRyOH7WRI3V/z QZ/uQ4ziUFJYT6xAJc1GYvTqVaxvIcteTqeCs4rOBwu5D1TRQLqrlqAA/nnv7xqTmsSo ow9+svF809jEPTiObXNpvgLIYdSG3kexyI1j8DaetKRoz3oUpx1IBzgFasGpwJUjdkAn Wc09uwbM5Y1orw0fHnQa2V2lBKX9b9hcqy/bPJNJMxhSZyZo49wIpbQGntdtj8esSRX1 GRJeJICiyrw0ii1mWSHw83NB0ggQchQ0QQxAwlIo+tWyvGCZ6knNGVaD08HXoIrC/8Ve wrvQ== Received: by 10.224.183.18 with SMTP id ce18mr1232081qab.90.1347972659205; Tue, 18 Sep 2012 05:50:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.49.12.19 with HTTP; Tue, 18 Sep 2012 05:50:39 -0700 (PDT) In-Reply-To: References: From: David Nalley Date: Tue, 18 Sep 2012 08:50:39 -0400 Message-ID: Subject: Re: unit tests for api/src/com/cloud/agent/api To: cloudstack-dev@incubator.apache.org Cc: Prasanna Santhanam Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQl9nkBzIShnt592qGwOOb3R2YG+JIbG3GDQ/ojMJXClTXXuef6ZdZQQ/DubkRGbJ5NOCiaw On Mon, Sep 17, 2012 at 7:24 PM, Edison Su wrote: > First, thanks for working on test stuff, we really need more automate tes= t cases. > If you plan to work on the API test, we have a python test framework: htt= ps://cwiki.apache.org/CLOUDSTACK/testing-with-python.html. The most compell= ing feature is that it supports code completion for cloudstack API, very ea= sy to write test case in Eclipse environment. And we are setting up a test = infrastructure, which will execute all the test cases written for this fram= ework. > We already have around 500+ test cases, or maybe more, but apparently it'= s not enough. If you like to work on it, that will be great! > While I like the functional/integration tests, as you note we have 500+ currently. Those tests also take many hours to run at present. Unit tests should be something fast, a sanity check, and we only have 25 right now for the entire code base, so while I like func/integration tests, I'd really like for our unit tests to be runnable on every commit, and provide some decent level of coverage so that we have a bit of confidence that code works well, and provide good feedback to folks on whether their commit passes the sniff test. --David