Return-Path: 
 <cloudstack-dev-return-6975-apmail-incubator-cloudstack-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BBDB8D3CC
	for <apmail-incubator-cloudstack-dev-archive@minotaur.apache.org>;
 Mon, 24 Sep 2012 06:43:22 +0000 (UTC)
Received: (qmail 12494 invoked by uid 500); 24 Sep 2012 06:43:22 -0000
Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org
Received: (qmail 12284 invoked by uid 500); 24 Sep 2012 06:43:19 -0000
Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:cloudstack-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:cloudstack-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:cloudstack-dev@incubator.apache.org>
List-Id: <cloudstack-dev.incubator.apache.org>
Reply-To: cloudstack-dev@incubator.apache.org
Delivered-To: mailing list cloudstack-dev@incubator.apache.org
Received: (qmail 12247 invoked by uid 99); 24 Sep 2012 06:43:17 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 06:43:17 +0000
X-ASF-Spam-Status: No, hits=0.6 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Received: from [74.125.149.209] (HELO na3sys009aog113.obsmtp.com)
 (74.125.149.209)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 06:43:09 +0000
Received: from mail-qc0-f175.google.com ([209.85.216.175]) (using TLSv1) by
 na3sys009aob113.postini.com ([74.125.148.12]) with SMTP
	ID DSNKUGAA5S37r96T6SrvpKtWLj17ndKLqTon@postini.com;
 Sun, 23 Sep 2012 23:42:48 PDT
Received: by qcad10 with SMTP id d10so4278951qca.6
        for <cloudstack-dev@incubator.apache.org>;
 Sun, 23 Sep 2012 23:42:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:x-gm-message-state;
        bh=H1AFNo6gjEkZ0FEJUhQWhQT7QYXgHB8sHlt7BrtUYtI=;
        b=nh64PaqXPmbRWlrdyvxxZShvKxQeGB3kPA0Z4oASAVgsvENTq96lgSUoVTWSfPHX+z
         chhh4GIkd+WAx4YMnATyq2Oc/jsnNU74UIVZ7AK85J8aKHsSvQKX5xVhjrnAiT5bm/sB
         5gO2NmkonEBLFT1EQrJ3PK1eBVmw11IqLY9J2wgUpiEdNhzCuUVrnI31v53y+o3KRY0N
         SR+L+5HotOJQdWJNYYz9EMmDjpokfwVFsAs4iNcibho9zL9jsa87Gko5TnalQsICqTL/
         aWuh09JFEH6WoOynSQUyfOWS7xTnvHt9v588nJXfbIrIGTx2HzC3daJCHMh2ak239TWi
         NDTw==
MIME-Version: 1.0
Received: by 10.229.171.221 with SMTP id i29mr4800770qcz.15.1348468965162;
 Sun, 23 Sep 2012 23:42:45 -0700 (PDT)
Received: by 10.49.40.231 with HTTP; Sun, 23 Sep 2012 23:42:45 -0700 (PDT)
In-Reply-To: 
 <CA+96GG71358EiKo4Xbmxuv+Hc=4AfP4kMkFJKyPwnO7xs4NP=A@mail.gmail.com>
References: <20120921034138.4009.65916@reviews.apache.org>
	<CA+96GG71358EiKo4Xbmxuv+Hc=4AfP4kMkFJKyPwnO7xs4NP=A@mail.gmail.com>
Date: Mon, 24 Sep 2012 12:12:45 +0530
Message-ID: 
 <CACguOvj8wgi-qrA5Z_jZhKmcS=mmPJ4gk_W4SJfcb5VNMK1A4w@mail.gmail.com>
Subject: Re: Review Request: unit test suite for api project
From: Manikanta Kattamuri <manikanta.kattamuri@sungard.com>
To: cloudstack-dev@incubator.apache.org
Cc: Yichi Lu <yichi.lu@sungard.com>
Content-Type: multipart/alternative; boundary=0016369c889da8bfcb04ca6ce51e
X-Gm-Message-State: 
 ALoCoQl9p0wREewQ13zUskcVMbGw9DOtzCD5gstdimpVSTyPyGtSZ7aUpgPKwHhRF++yCf4OdDcD

--0016369c889da8bfcb04ca6ce51e
Content-Type: text/plain; charset=ISO-8859-1

As per yichi's comments i see that the unit testes would be located in
unittest folder, why not keep them in the standard maven structure.

src/test/java/<package structure>

Mani

On Sat, Sep 22, 2012 at 1:59 AM, Chip Childers <chip.childers@sungard.com>wrote:

> All,
>
> I'd like to create a branch for some of the JUnit tests that Yichi is
> creating.  That way, we can accept the tests into the codebase (after
> reviews), but not apply them to master until 4.0 is stabilized.  Any
> thoughts, questions or concerns?
>
> -chip
>
> On Thu, Sep 20, 2012 at 11:41 PM, Yichi Lu <yichi.lu@sungard.com> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7204/
> > -----------------------------------------------------------
> >
> > Review request for cloudstack.
> >
> >
> > Description
> > -------
> >
> > A junit test suite against api project. All unit tests are to be
> executed at the api/unittest directory level by running "$ mvn test".
> > A directory: unittest was created under the project api.
> > The unit tests are used to test java classes and their methods. They are
> intended to complement, not replace, the existing tests written in python
> marvin.
> > packages used: surefire (v2.12.3), junit (v4.8.2).
> > While this particular suite is junit test suite against api project, it
> is envisioned that eventually other suites be developed against other
> cloudstack projects.
> >
> >
> > Diffs
> > -----
> >
> >   .gitignore d772031
> >   api/pom.xml db14775
> >   api/unittest/.gitignore PRE-CREATION
> >   api/unittest/pom.xml PRE-CREATION
> >   api/unittest/src/com/cloud/agent/api/.gitignore PRE-CREATION
> >   api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java
> PRE-CREATION
> >   pom.xml ef478a3
> >
> > Diff: https://reviews.apache.org/r/7204/diff/
> >
> >
> > Testing
> > -------
> >
> > One test class, AttachIsoCommand.java, with one test case against
> getVmName() method of api/src/com/cloud/agent/api/AttachIsoCommand class.
> >
> >
> > USLT-205731:unittest yichi.lu$ pwd
> > /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest
> > USLT-205731:unittest yichi.lu$ mvn test
> > [INFO] Scanning for projects...
> > [INFO]
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] Building Apache CloudStack API Unittest 4.0.0-SNAPSHOT
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO]
> > [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
> cloud-api-unittest ---
> > [debug] execute contextualize
> > [INFO] Using 'UTF-8' encoding to copy filtered resources.
> > [INFO] skip non existing resourceDirectory /Users/
> yichi.lu/CloudStack/incubator-cloudstack/api/unittest/src/main/resources
> > [INFO]
> > [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @
> cloud-api-unittest ---
> > [INFO] Compiling 221 source files to /Users/
> yichi.lu/CloudStack/incubator-cloudstack/api/unittest/target/classes
> > [INFO]
> > [INFO] --- maven-resources-plugin:2.5:testResources
> (default-testResources) @ cloud-api-unittest ---
> > [debug] execute contextualize
> > [INFO] Using 'UTF-8' encoding to copy filtered resources.
> > [INFO] Copying 0 resource
> > [INFO]
> > [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile)
> @ cloud-api-unittest ---
> > [INFO] Compiling 1 source file to /Users/
> yichi.lu/CloudStack/incubator-cloudstack/api/unittest/src/com/cloud/agent/api
> > [INFO]
> > [INFO] --- maven-surefire-plugin:2.10:test (default-test) @
> cloud-api-unittest ---
> > [INFO] Surefire report directory: /Users/
> yichi.lu/CloudStack/incubator-cloudstack/api/unittest/target/surefire-reports
> >
> > -------------------------------------------------------
> >  T E S T S
> > -------------------------------------------------------
> > Running com.cloud.agent.api.AttachIsoCommandTest
> > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.097 sec
> >
> > Results :
> >
> > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> >
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] BUILD SUCCESS
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] Total time: 7.546s
> > [INFO] Finished at: Thu Sep 20 22:31:38 CDT 2012
> > [INFO] Final Memory: 11M/554M
> > [INFO]
> ------------------------------------------------------------------------
> > U
> >
> >
> > Thanks,
> >
> > Yichi Lu
> >
>
>

--0016369c889da8bfcb04ca6ce51e--