Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of Edison.su@citrix.com
 designates 66.165.176.63 as permitted sender)
From: Edison Su <Edison.su@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>
Date: Thu, 6 Sep 2012 15:36:46 -0700
Subject: RE: Review Request: maven kvm hypervisor plugin build without
 -Dnonoss
Thread-Topic: Review Request: maven kvm hypervisor plugin build without
 -Dnonoss
Thread-Index: Ac2Mfppliub6AKI1QL+zQ6pj7ETiNQAAVzBg
Message-ID: 
 <C66C814C1ABFA8449FF65CB44953A8B4012CBB65BC66@SJCPMAILBOX01.citrite.net>
References: <20120905103850.583.2968@reviews.apache.org>
	<20120906170426.591.95278@reviews.apache.org>
	<CALFpzo72E4HjD5HRF-mSQzdJu7Zwom0NmsCqyO4Ce6gRPuUvCQ@mail.gmail.com>
	<504907FA.90103@widodh.nl>
	<CAKprHVbxNN-QFP6VhZd-VKmhFfvNEKhdzjR8HNy6w_vYhngWhA@mail.gmail.com>
 <CALFpzo7Tkyu7VVzOJ4OrBtj7jhEupgb2HEhg8Ty6MUfPeiFC3A@mail.gmail.com>
In-Reply-To: 
 <CALFpzo7Tkyu7VVzOJ4OrBtj7jhEupgb2HEhg8Ty6MUfPeiFC3A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

I'll add a switch to enable and disable kvm.

> -----Original Message-----
> From: Marcus Sorensen [mailto:shadowsor@gmail.com]
> Sent: Thursday, September 06, 2012 3:25 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Review Request: maven kvm hypervisor plugin build without
> -Dnonoss
>=20
> You can disable it in the default build, but still allow it in waf
> build, correct? Or at the very least it seems that the RPM build
> should ship building the agent with a message saying 'do x y z to
> enable KVM first' or some such.
>=20
> Nobody is going to build an RPM and not want KVM support, it's not
> like the citrix or Vmware resources can be used with RHEL/CentOS.
>=20
> On Thu, Sep 6, 2012 at 3:40 PM, David Nalley <david@gnsa.us> wrote:
> > On Thu, Sep 6, 2012 at 4:30 PM, Wido den Hollander <wido@widodh.nl>
> wrote:
> >>
> >>
> >> On 09/06/2012 08:05 PM, Marcus Sorensen wrote:
> >>>
> >>> Trying to get a working RPM build of 4.0 going... I assume my
> latest
> >>> issue is related to this.  "class not found:
> >>> com.cloud.hypervisor.kvm.resource.LibvirtComputingResource", if
> >>> someone is building RPMs isn't it safe to assume they want the
> >>> kvm/libvirt pieces?  What was Wido's fix? I don't see this patch
> >>> applied to maven-waf, just 623f199b0378683e6f5f0c2b2b5c692b6504d16f
> as
> >>> latest.
> >>
> >>
> >> Sorry, I completely missed this review!
> >>
> >> The legal issue with KVM was approved like Elan posted, see LEGAL-
> 144 as I
> >> mentioned in the commit message.
> >>
> >> I saw Elan's post on the ml, checked out the legal status and
> enabled KVM
> >> again since we were allowed to do so :)
> >>
> >> Wido
> >>
> >
> >
> > I am not sure that this is my understanding.
> > Doesn't the 'default build option' have to miss KVM because it
> > currently doesn't have a license that permits it? Or did we decide to
> > identify this as a system dependency?
> >
> > I know we got blessing to produce KVM-inclusive convenience binaries,
> > but point 1 of the accepted proposal in LEGAL-144 says:
> >  Disable KVM support in the default build, as per policy.
> >
> > --David