Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97230DEBB for ; Thu, 27 Sep 2012 05:07:00 +0000 (UTC) Received: (qmail 87783 invoked by uid 500); 27 Sep 2012 05:07:00 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 87577 invoked by uid 500); 27 Sep 2012 05:06:59 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 87559 invoked by uid 99); 27 Sep 2012 05:06:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Sep 2012 05:06:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7973F1C439E; Thu, 27 Sep 2012 05:06:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6146883209361606024==" MIME-Version: 1.0 Subject: Re: Review Request: cloud.spec: run modprobe post agent install if kvm.modules exists From: "edison su" To: "Marcus Sorensen" , "cloudstack" , "edison su" Date: Thu, 27 Sep 2012 05:06:57 -0000 Message-ID: <20120927050657.18994.4231@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "edison su" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7307/ X-Sender: "edison su" References: <20120927042343.18994.28212@reviews.apache.org> In-Reply-To: <20120927042343.18994.28212@reviews.apache.org> Reply-To: "edison su" --===============6146883209361606024== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7307/#review11963 ----------------------------------------------------------- Ship it! Ship It! - edison su On Sept. 27, 2012, 4:23 a.m., Marcus Sorensen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7307/ > ----------------------------------------------------------- > = > (Updated Sept. 27, 2012, 4:23 a.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > This should alleviate reports that the host OS has to be rebooted after a= gent install because host says that HVM isn't supported. Libvirtd doesn't s= eem to need to be restarted, it reports capabilities accordingly. > = > = > Diffs > ----- > = > cloud.spec 67064b3 = > = > Diff: https://reviews.apache.org/r/7307/diff/ > = > = > Testing > ------- > = > Verified that kvm.modules is run after agent install if it exists and is = executable. I don't think libvirtd needs to be restarted since I also teste= d what a capabilities call shows pre and post modprobe, and it changes acco= rdingly without a libvirtd restart. > = > = > Thanks, > = > Marcus Sorensen > = > --===============6146883209361606024==--