Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92D81D8BD for ; Wed, 26 Sep 2012 15:32:53 +0000 (UTC) Received: (qmail 99004 invoked by uid 500); 26 Sep 2012 15:32:53 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 98962 invoked by uid 500); 26 Sep 2012 15:32:53 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 98950 invoked by uid 99); 26 Sep 2012 15:32:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 15:32:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5DD61C4270; Wed, 26 Sep 2012 15:32:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4276339228600665926==" MIME-Version: 1.0 Subject: Re: Review Request: CloudStack CS-15644 Pass uuid to resource layer in Autoscale instead of Ids From: "Vijay Venkatachalam" To: "Vijay Venkatachalam" , "Pranav Saxena" , "Devdeep Singh" Cc: "cloudstack" , "Deepak Garg" Date: Wed, 26 Sep 2012 15:32:51 -0000 Message-ID: <20120926153251.18991.59243@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vijay Venkatachalam" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7205/ X-Sender: "Vijay Venkatachalam" References: <20120926104024.18994.91203@reviews.apache.org> In-Reply-To: <20120926104024.18994.91203@reviews.apache.org> Reply-To: "Vijay Venkatachalam" --===============4276339228600665926== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7205/#review11931 ----------------------------------------------------------- Ship it! Ship It! - Vijay Venkatachalam On Sept. 26, 2012, 10:40 a.m., Deepak Garg wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7205/ > ----------------------------------------------------------- > = > (Updated Sept. 26, 2012, 10:40 a.m.) > = > = > Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Vijay Ve= nkatachalam. > = > = > Description > ------- > = > Ids are used instead of UUIds for entities like template, serviceoffering= . Since NS will be making api calls on MS, so its better to use UUIDs = > = > = > This addresses bug CS-15644. > = > = > Diffs > ----- > = > api/src/com/cloud/agent/api/to/LoadBalancerTO.java 04f718e = > api/src/com/cloud/network/as/AutoScaleVmGroup.java 7b882fc = > api/src/com/cloud/network/lb/LoadBalancingRule.java e9cb6da = > api/src/com/cloud/network/rules/LoadBalancer.java 9c67f29 = > plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/= ElasticLoadBalancerManagerImpl.java 57e631e = > plugins/network-elements/netscaler/src/com/cloud/network/element/Netsca= lerElement.java 1b5f17a = > plugins/network-elements/netscaler/src/com/cloud/network/resource/Netsc= alerResource.java 1a53e4d = > server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java= ba3d689 = > server/src/com/cloud/network/as/AutoScaleVmGroupVO.java 3de9f9b = > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 82b4= dd4 = > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.= java 163252f = > = > Diff: https://reviews.apache.org/r/7205/diff/ > = > = > Testing > ------- > = > a. Manually tested with the Basic EIP/ELB zone by creating the autoscale = entities and AutoScaleVMGroup, then checking the string passed in the NetSc= aler Box. > b. On firing the command string obtained from the NetScaler Box, a VM get= s deployed. > = > = > Thanks, > = > Deepak Garg > = > --===============4276339228600665926==--