Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D136D996 for ; Mon, 24 Sep 2012 11:02:32 +0000 (UTC) Received: (qmail 40277 invoked by uid 500); 24 Sep 2012 11:02:32 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 40027 invoked by uid 500); 24 Sep 2012 11:02:31 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 40014 invoked by uid 99); 24 Sep 2012 11:02:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 11:02:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5BED51C0A3D; Mon, 24 Sep 2012 11:02:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8173069395744949468==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-43 : Jenkins build process needs to allow for setting the appropriate version number within the built JARs. From: "Rohit Yadav" To: "Chip Childers" , "edison su" Cc: "cloudstack" , "Pradeep Soundararajan" , "Rohit Yadav" Date: Mon, 24 Sep 2012 11:02:30 -0000 Message-ID: <20120924110230.18991.440@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7083/ X-Sender: "Rohit Yadav" References: <20120924105624.18992.65315@reviews.apache.org> In-Reply-To: <20120924105624.18992.65315@reviews.apache.org> Reply-To: "Rohit Yadav" --===============8173069395744949468== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Sept. 24, 2012, 10:56 a.m., Rohit Yadav wrote: > > Ship It! Note: The patch is find, but the refactoring of version tags to top level p= om has one issue. If you now cd to a submodule and do mvn , it will fail in most cases. As submodule poms won't know where to get g= lobal variables. One solution in that case is to select a project, we need to build etc., li= ke mvn -pl Other solution is to set relative path to parent as done in plugins/** org.apache.cloudstack cloudstack-plugins ${cs.version} ../../pom.xml - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7083/#review11827 ----------------------------------------------------------- On Sept. 24, 2012, 10:48 a.m., Pradeep Soundararajan wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7083/ > ----------------------------------------------------------- > = > (Updated Sept. 24, 2012, 10:48 a.m.) > = > = > Review request for cloudstack, Chip Childers and edison su. > = > = > Description > ------- > = > The Jenkins binary build processes are producing JAR files that contain v= ersion numbers like 4.0.0-SNAPSHOT. We need a way to set a parameter within= the build to set the version from SNAPSHOT to RC1 or even drop the pre-rel= ease identifier entirely (so that we can generate an actual release). = > = > >> Removed the occurrences of SNAPSHOT > = > = > Diffs > ----- > = > agent/pom.xml a559580 = > api/pom.xml db14775 = > awsapi/pom.xml a583384 = > client/pom.xml 50b85e9 = > cloud.spec c1fe56a = > console-proxy/pom.xml 8bfb753 = > core/pom.xml 510cb04 = > debian/cloud-deps.install 74aade1 = > deps/XenServerJava/pom.xml 1337514 = > deps/pom.xml 1e20083 = > patches/pom.xml d62fc86 = > plugins/deployment-planners/user-concentrated-pod/pom.xml ca2fae1 = > plugins/deployment-planners/user-dispersing/pom.xml 6e1ffc6 = > plugins/file-systems/netapp/pom.xml f10e5a4 = > plugins/host-allocators/random/pom.xml ad66c0e = > plugins/hypervisors/kvm/pom.xml 4863085 = > plugins/hypervisors/ovm/pom.xml a8b23d0 = > plugins/hypervisors/vmware/pom.xml 435ae38 = > plugins/hypervisors/xen/pom.xml bf38e47 = > plugins/network-elements/elastic-loadbalancer/pom.xml c1ab2c5 = > plugins/network-elements/f5/pom.xml 0cba48c = > plugins/network-elements/juniper-srx/pom.xml 38a2b55 = > plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 = > plugins/network-elements/netscaler/pom.xml 377e6e0 = > plugins/network-elements/nicira-nvp/pom.xml 37c3a3a = > plugins/network-elements/ovs/pom.xml 02d455c = > plugins/pom.xml 206d4a1 = > plugins/storage-allocators/random/pom.xml 6cb60cd = > plugins/user-authenticators/ldap/pom.xml 7facc3f = > plugins/user-authenticators/md5/pom.xml 1dac92d = > plugins/user-authenticators/plain-text/pom.xml a4280a3 = > pom.xml 49a71a1 = > server/pom.xml f7178d8 = > test/pom.xml f70a89f = > usage/pom.xml 92e5e72 = > utils/pom.xml e8d7827 = > vmware-base/pom.xml 1dabe83 = > wscript_build 4264822 = > = > Diff: https://reviews.apache.org/r/7083/diff/ > = > = > Testing > ------- > = > Able to execute mvn install successfully after the changes... > = > = > Thanks, > = > Pradeep Soundararajan > = > --===============8173069395744949468==--