cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in
Date Tue, 25 Sep 2012 07:56:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7130/
-----------------------------------------------------------

(Updated Sept. 25, 2012, 7:56 a.m.)


Review request for cloudstack, Abhinandan Prateek, Alena Prokharchyk, and Alex Huang.


Changes
-------

New patch.

A better solution would be to change how UserAccount gets and sets States, which is String
now. But, this would possibly affect or break at many places so I fixed it by getting State
enum and converting to string and equating (ignore case) against UserAccount.getState()


Description
-------

Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-121

Download original patch and git am <patch>:
http://bhaisaab.org/patches/cloudstack/0001-CLOUDSTACK-121-Fix-NullPointerException-for-incorrec.patch


Diffs (updated)
-----

  api/src/com/cloud/user/UserAccount.java 734e16b 
  server/src/com/cloud/user/AccountManagerImpl.java fa9fafb 

Diff: https://reviews.apache.org/r/7130/diff/


Testing
-------


Thanks,

Rohit Yadav


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message