cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Review Request: CLOUDSTACK-84: FIX NPE error in listRouter etc. after deleting a user project.
Date Wed, 19 Sep 2012 15:38:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7168/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, Nitin Mehta, Alena Prokharchyk,
and Alex Huang.


Description
-------

Domain ACL information should be valid even if account entry is marked
removed. Patch fixes how account is obtained based on accountId, it
finds among those entries which are marked deleted.

In case of project deletion, the project is marked removed first and
then each of its elements are cleared/cleaned/deleted. While deleting
network and router it failed because ACL only checks accounts which are
not marked deleted.

Download original patch and git am <patch>: http://patchbin.baagi.org/p?id=40pdym


This addresses bug CLOUDSTACK-84.


Diffs
-----

  server/src/com/cloud/acl/DomainChecker.java 6bc2cd3 
  server/src/com/cloud/user/dao/AccountDao.java 3b7fa66 
  server/src/com/cloud/user/dao/AccountDaoImpl.java 7300bb1 

Diff: https://reviews.apache.org/r/7168/diff/


Testing
-------


Thanks,

Rohit Yadav


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message