cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request: KVM initial VPC support
Date Sat, 01 Sep 2012 05:11:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6883/
-----------------------------------------------------------

(Updated Sept. 1, 2012, 5:11 a.m.)


Review request for cloudstack.


Changes
-------

Updated patch to address Edison's notes. Also some minor fixes to formatting and removing
some of the superfluous debug code. Tested again (rebooted VPC router with newer code installed,
verified functionality)


Description
-------

Implements SetupGuestNetworkCommand,SetNetworkACLCommand,SetSourceNatCommand,IpAssocVpcCommand,SetPortForwardingRulesVpcCommand.
Passes basic functionality, though I'm sure there may be some honing to do.

Also fixes a few minor things found along the way:
 vpc_guestnw.sh wasn't successfully setting up apache due to default listen IP of 10.1.1.1
 vpc_guestnw.sh was referencing a 'logger_it' function, replaced with 'logger -t cloud'
 system vms were running with OS type "Debian GNU/Linux 5.0(32-bit)", which was not found
in the KVMGuestOsMapper
 the Xen implementation of SetupGuestNetworkCommand had apparently copied its catch message
from UnPlug Nic, fixed string


Diffs (updated)
-----

  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 965dd63 
  patches/systemvm/debian/config/opt/cloud/bin/vpc_guestnw.sh be0ad96 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMGuestOsMapper.java e3615ad

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
7e8a11c 
  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java a6efdf7


Diff: https://reviews.apache.org/r/6883/diff/


Testing
-------

created VPC, added 3 tiers, added 3 vms, set up acls for ICMP between all tiers, TCP outbound
on all tiers. Tested traffic between VMs on all three networks. Added IPs, created portforwarding
rule port 22 to VM on network 3, added TCP port 22 ingress rule for network 3, SSH'ed into
the VM via public IP. Rebooted VPC router and tested everything again.


Thanks,

Marcus Sorensen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message