Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of Vijay.Venkatachalam@citrix.com
 designates 203.166.19.134 as permitted sender)
From: Vijay Venkatachalam <Vijay.Venkatachalam@citrix.com>
To: Chiradeep Vittal <Chiradeep.Vittal@citrix.com>, CloudStack DeveloperList
	<cloudstack-dev@incubator.apache.org>
CC: Pranav Saxena <pranav.saxena@citrix.com>, David Nalley
	<David.Nalley@citrix.com>, Alena Prokharchyk <Alena.Prokharchyk@citrix.com>,
	Deepak Garg <deepak.garg@citrix.com>
Date: Thu, 16 Aug 2012 23:13:57 +0530
Subject: RE: AutoScale comments.....(WAS:RE: where features are developed
 was: Review Request: Merge Kelven's VPC code for Vmware into asf vpc branch)
Thread-Topic: AutoScale comments.....(WAS:RE: where features are developed
 was: Review Request: Merge Kelven's VPC code for Vmware into asf vpc branch)
Thread-Index: Ac170dO69ez5jY0jSlyd0dXLabwW2wAAOWtg
Message-ID: 
 <33740054EBF5B64BB213E2E0916F2C13EA11956239@BANPMAILBOX01.citrite.net>
References: 
 <35F04D4C394874409D9BE4BF45AC5EA9FED6689A2B@BANPMAILBOX01.citrite.net>
 <CC5277D2.2B55D%chiradeep.vittal@citrix.com>
In-Reply-To: <CC5277D2.2B55D%chiradeep.vittal@citrix.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0


> -----Original Message-----
> From: Chiradeep Vittal
> Sent: Thursday, August 16, 2012 10:42 PM
> To: CloudStack DeveloperList
> Cc: Pranav Saxena; David Nalley; Vijay Venkatachalam; Alena Prokharchyk;
> Deepak Garg
> Subject: Re: AutoScale comments.....(WAS:RE: where features are
> developed was: Review Request: Merge Kelven's VPC code for Vmware into
> asf vpc branch)
>=20
> Can you address 3-6 ?
>=20
> >> 3. Any indexes at all on these new tables?

	Sure will introduce them as appropriate for each of the tables.=20
	Will file a bug to track this as well.

> >> 4. autoscale_vmprofiles (and java class) should not have reference to
> >> snmp. We discussed why before, and alternatives to this design on
> >> this mailing list.

	Sorry I could not bring up that email back, but it was something like=20
	key-value pair.=20
	Could you please give a brief explanation of what is the alternative?
	Or if there is an example already in cloudstack can you point me to that?

> >> 5. A lot of the changes to existing files are whitespace changes that
> >> are unrelated to the logic. Please avoid this.

	Sure will remove them and will configure my Eclipse IDE to avoid=20
	this in future. Is there any other way?

> >> 6. Why is a Counter not a ControlledEntity but Condition is?


	Counter is at system level and is packaged by default/built-in or could=20
	be added by root admin. But conditions are configured by tenants based
	on their use-case. For ex. CPU > 80

> >
> >> 8. The License header is not consistent (some with leading spaces,
> >> others
> >> without)
> >> 9. Not all files have the Apache license.
> >>
	Will look into it and do the needful.
> >
> >Thanks,
> >Ram
> >