Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E7D7D7C3 for ; Fri, 24 Aug 2012 09:38:48 +0000 (UTC) Received: (qmail 70465 invoked by uid 500); 24 Aug 2012 09:38:48 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 70318 invoked by uid 500); 24 Aug 2012 09:38:47 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 70270 invoked by uid 99); 24 Aug 2012 09:38:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2012 09:38:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5FC2D1C1BEB; Fri, 24 Aug 2012 09:38:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9095242763267449047==" MIME-Version: 1.0 Subject: Re: Review Request: Pick newer system VM template for vmware in latest cloudstack release. From: "Kishan Kavala" To: "Kishan Kavala" Cc: "cloudstack" , "Venkata Siva Vijayendra Bhamidipati" Date: Fri, 24 Aug 2012 09:38:45 -0000 Message-ID: <20120824093845.1112.17272@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kishan Kavala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6702/ X-Sender: "Kishan Kavala" References: <20120821012337.15256.38240@reviews.apache.org> In-Reply-To: <20120821012337.15256.38240@reviews.apache.org> Reply-To: "Kishan Kavala" --===============9095242763267449047== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6702/#review10726 ----------------------------------------------------------- server/src/com/cloud/upgrade/dao/Upgrade2214to30.java to get current version, query should be = select version from version order by id desc limit 1; server/src/com/cloud/upgrade/dao/Upgrade2214to30.java Vmware template upgrade code should go into Upgrade302to40. In Upgrade2214to30 for Vmware case, template upgrade can be removed com= pletely. Older versions (< 302) won't have this code anyway. No need to sel= ectively pick template. - Kishan Kavala On Aug. 21, 2012, 1:23 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6702/ > ----------------------------------------------------------- > = > (Updated Aug. 21, 2012, 1:23 a.m.) > = > = > Review request for cloudstack and Kishan Kavala. > = > = > Description > ------- > = > Modifying reference to system VM template for vmware for the 2.2.14 to 3.= 0 upgrade path so that it picks up the burbank template if upgrading from 2= .2.14 to 3.0.5 or beyond, and the acton template if upgrading from 2.2.14 t= o 3.0.[0-4]. > = > = > This addresses bug CS-16075. > = > = > Diffs > ----- > = > server/src/com/cloud/maint/Version.java 184b9a6 = > server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 43e2c00 = > = > Diff: https://reviews.apache.org/r/6702/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Venkata Siva Vijayendra Bhamidipati > = > --===============9095242763267449047==--