Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39841CBF1 for ; Sat, 11 Aug 2012 01:13:27 +0000 (UTC) Received: (qmail 18893 invoked by uid 500); 11 Aug 2012 01:13:27 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 18874 invoked by uid 500); 11 Aug 2012 01:13:27 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 18861 invoked by uid 99); 11 Aug 2012 01:13:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Aug 2012 01:13:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8668C1C0967; Sat, 11 Aug 2012 01:13:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8196735866552037394==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15823 Failed snapshot should be marked as Error and cleanup asynchronously From: "mice xia" To: "edison su" , "Nitin Mehta" Cc: "Sateesh Chodapuneedi" , "cloudstack" , "mice xia" Date: Sat, 11 Aug 2012 01:13:25 -0000 Message-ID: <20120811011325.5557.46424@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "mice xia" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6325/ X-Sender: "mice xia" References: <20120803000301.22302.32463@reviews.apache.org> In-Reply-To: <20120803000301.22302.32463@reviews.apache.org> Reply-To: "mice xia" --===============8196735866552037394== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6325/ ----------------------------------------------------------- (Updated Aug. 11, 2012, 1:13 a.m.) Review request for cloudstack, Nitin Mehta and edison su. Changes ------- marked failed snapshots as Error and expunge them in a background thread, t= he cleanup interval is storage.cleanup.interval Summary (updated) ----------------- CS-15823 Failed snapshot should be marked as Error and cleanup asynchronous= ly Description (updated) ------- changes: marked failed snapshots as Error and expunge them in a background thread, t= he cleanup interval is storage.cleanup.interval This addresses bug CS-15823. Diffs (updated) ----- server/src/com/cloud/storage/StorageManagerImpl.java c17379f = server/src/com/cloud/storage/dao/SnapshotDao.java 4bf54de = server/src/com/cloud/storage/dao/SnapshotDaoImpl.java ac4bb6f = server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 6e3f9c1 = Diff: https://reviews.apache.org/r/6325/diff/ Testing ------- verified Thanks, mice xia --===============8196735866552037394==--