Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAFCB9AA0 for ; Thu, 2 Aug 2012 00:58:40 +0000 (UTC) Received: (qmail 63428 invoked by uid 500); 2 Aug 2012 00:58:40 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 63405 invoked by uid 500); 2 Aug 2012 00:58:40 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 63394 invoked by uid 99); 2 Aug 2012 00:58:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2012 00:58:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A5F4A1C1924; Thu, 2 Aug 2012 00:58:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0163247426429484143==" MIME-Version: 1.0 Subject: Re: Review Request: POC VIF plugin implementation From: "Tomoe Sugihara" To: "Chiradeep Vittal" Cc: "cloudstack" , "edison su" , "Tomoe Sugihara" Date: Thu, 02 Aug 2012 00:58:39 -0000 Message-ID: <20120802005839.22302.55757@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Tomoe Sugihara" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6285/ X-Sender: "Tomoe Sugihara" References: <20120801210822.22301.98474@reviews.apache.org> In-Reply-To: <20120801210822.22301.98474@reviews.apache.org> Reply-To: "Tomoe Sugihara" --===============0163247426429484143== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 1, 2012, 9:08 p.m., edison su wrote: > > Do you miss the LibvirtVifDriver file? And, please separate the network= code from libvirtcomputingresource. Ah, Yes. Thanks for the review. I will work on separating out the network c= ode and will submit patches. - Tomoe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9714 ----------------------------------------------------------- On Aug. 1, 2012, 4:42 p.m., Tomoe Sugihara wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6285/ > ----------------------------------------------------------- > = > (Updated Aug. 1, 2012, 4:42 p.m.) > = > = > Review request for cloudstack and Chiradeep Vittal. > = > = > Description > ------- > = > POC VIF plugin implementation > ----------------------------- > = > - This allows vendors to implement their of plug/unplug logic, and users = can choose one by specifying "libvirt.vif.driver" parameter in agent.proper= ties file. > - if it is not specified, it defaults to the current implementation wit= h Linux bridge. > - This work is still half way in that: > - unplug hasn't been implemented > - I was going to factor out the existing default implementation with Li= nux bridge to something like LibvirtBridgeVifDriver, but there's a bunch of= dependencies (on methods and fields in LibvirtComputingResource and Virtua= lRoutingResource) and I couldn't finish it. Ultimately, all the networking = specific logic should be separated from LibvirtComputingResource to vif dri= ver. > = > = > = > Diffs > ----- > = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtCo= mputingResource.java ea12b986b0a771c028354637a657b100fc3cfa27 = > = > Diff: https://reviews.apache.org/r/6285/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Tomoe Sugihara > = > --===============0163247426429484143==--