cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject RE: Review Request: CS-15833: PreparForMigrationCommand should extend base Command object
Date Mon, 13 Aug 2012 10:55:29 GMT
Done.

-----Original Message-----
From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf Of Prasanna Santhanam
Sent: Monday, August 13, 2012 4:09 PM
To: Edison Su; Alex Huang; Nitin Mehta
Cc: cloudstack; Prasanna Santhanam
Subject: Re: Review Request: CS-15833: PreparForMigrationCommand should extend base Command
object



> On Aug. 3, 2012, 11:44 a.m., Nitin Mehta wrote:
> > Ship It!

Can this be applied so I can close the request? Thanks


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6338/#review9824
-----------------------------------------------------------


On Aug. 3, 2012, 10:46 a.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6338/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 10:46 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta, edison su, and Alex Huang.
> 
> 
> Description
> -------
> 
> Download original patch: http://patchbin.baagi.org/p?id=l7fzrl
> 
> The PrepareForMigrationCommand implemented by ServerResources wrongly implements StartCommand
used for starting a VM.
> 
> 
> This addresses bug http://bugs.cloudstack.org/browse/CS-15833.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/PrepareForMigrationCommand.java 866aaea 
> 
> Diff: https://reviews.apache.org/r/6338/diff/
> 
> 
> Testing
> -------
> 
> 1) ant clean-all build-all
> 2) ant run-simulator
> 3) ant run-marvin
> 4) Deployed a few VMs and put the host into maintenance and cancel maintenance
> 
> Host successfully reaches Maintenance state and comes back out of maintenance.
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>

Mime
View raw message