cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gavin Lee <gavin....@gmail.com>
Subject Re: "Failed to install: x != java.lang.String" when register ISO in CS 3.0.x
Date Fri, 24 Aug 2012 08:25:17 GMT
Hi, Edison
I'm sure I used the latest 3.0.x branch, and the issue persists still.
I checked the master branch, it's correct. here is the git-diff of the
master and 3.0.x branch:

--- a/master:core/src/com/cloud/storage/template/DownloadManagerImpl.java
+++ b/3.0.x:core/src/com/cloud/storage/template/DownloadManagerImpl.java
@@ -293,7 +293,7 @@ public class DownloadManagerImpl implements
DownloadManager {
             }
             byte[] md5sum = digest.digest();
             BigInteger bigInt = new BigInteger(1, md5sum);
-            checksum = String.format("%032x",bigInt);
+            checksum = String.format("%032x",bigInt.toString(16));
             return checksum;

Anyway, I will switch to master branch since 3.0.x was not updated for
more than 2 months.

Thanks.

On Fri, Aug 24, 2012 at 3:26 AM, Edison Su <Edison.su@citrix.com> wrote:
> I reverted the https://reviews.apache.org/r/6392/, because, it's wrong.
> I checked the latest 3.0.x branch(http://git.cloud.com/cgit/cloudstack-oss/log/?h=3.0.x),
which contains the correct fix.
> Gavin, are you using the latest 3.0 after 2012-05-29? As this bug is fixed at 2012-05-29.
>
>> -----Original Message-----
>> From: Rohit Yadav [mailto:rohit.yadav@citrix.com]
>> Sent: Thursday, August 23, 2012 3:48 AM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: "Failed to install: x != java.lang.String" when register
>> ISO in CS 3.0.x
>>
>> Hi Gavin,
>>
>> You're right. It got fixed before and was reverted and then was again
>> cherry-picked. The review: https://reviews.apache.org/r/6392/
>>
>> And then again got undone: https://git-wip-
>> us.apache.org/repos/asf?p=incubator-
>> cloudstack.git;a=commit;h=0307effcfa25c1ed4f4e642a0167b5376cdec140
>>
>> @Edison: Please check and fix, same issue:
>> https://reviews.apache.org/r/6392/
>>
>> Regards,
>> Rohit
>>
>> On 23-Aug-2012, at 3:52 PM, Gavin Lee <gavin.lxh@gmail.com> wrote:
>>
>> > Dears,
>> > I encountered the issue when register ISO, I googled and found
>> similar
>> > issue has beed fixed:
>> >
>> > http://bugs.cloudstack.org/browse/CS-
>> 15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> > http://bugs.cloudstack.org/browse/CS-15156#
>> >
>> > But I couldn't find the fix in apache git repo or cloud.com git repo.
>> >
>> > I'm using apache cloudstack 3.0.x,  when click the uploaded ISO, the
>> > UI display contains following message:
>> > Status      Failed to install: x != java.lang.String
>> >
>> > The log vmops.log doesn't show any exception but following
>> information:
>> >
>> > 2012-08-23 17:11:05,021 DEBUG [agent.transport.Request]
>> > (AgentManager-Handler-1:null) Seq 6-213123976: Processing:  { Ans: ,
>> > MgmtId: 52232246786, via: 6, Ver: v1, Flags
>> > : 10, [{"storage.DownloadAnswer":{"jobId":"4109c690-8f70-4908-a18d-
>> 74c841be1127","downloadPct":100,"errorString":"Download
>> > success, starting install ","downloadStatus":
>> > "DOWNLOAD_IN_PROGRESS","downloadPath":"/mnt/SecStorage/a40491d3-9a2a-
>> 3a76-81c2-
>> 50919a231d25/template/tmpl/2/210/dnld3846264172469715863tmp_","installP
>> ath":"template/tmp
>> >
>> l//2/210","templateSize":0,"templatePhySicalSize":0,"result":false,"det
>> ails":"Download
>> > success, starting install ","wait":0}}] }
>> >
>> > 2012-08-23 17:11:15,053 DEBUG [agent.transport.Request]
>> > (AgentManager-Handler-4:null) Seq 6-213123978: Processing:  { Ans: ,
>> > MgmtId: 52232246786, via: 6, Ver: v1, Flags
>> > : 10, [{"storage.DownloadAnswer":{"jobId":"4109c690-8f70-4908-a18d-
>> 74c841be1127","downloadPct":100,"errorString":"Failed
>> > to install: x != java.lang.String","downloadSta
>> > tus":"DOWNLOAD_ERROR","downloadPath":"/mnt/SecStorage/a40491d3-9a2a-
>> 3a76-81c2-
>> 50919a231d25/template/tmpl/2/210/dnld3846264172469715863tmp_","installP
>> ath":"template/tmpl
>> >
>> //2/210","templateSize":0,"templatePhySicalSize":0,"result":false,"deta
>> ils":"Failed
>> > to install: x != java.lang.String","wait":0}}] }
>> >
>> > If it's already fixed, please tell me where I can find it; Or I can
>> > help on this.
>> >
>> > Thanks.
>> >
>> > --
>> > Gavin
>



-- 
Gavin

Mime
View raw message