cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack
Date Sat, 11 Aug 2012 02:22:35 GMT
You probably need to do an interactive git rebase, and squash your
local commits into one. Then generate a patch from that clean commit.

- chip

Sent from my iPhone.

On Aug 10, 2012, at 10:03 PM, Krishna Sadasivam <ksadasiv@brocade.com> wrote:

> I changed the BrocadePluginTest.java to use org.apache.commons.codec.binary.Base64. When
I create a patch and try to upload to review board I get the following error:
>
> " The file 'plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java'
(r0b8fd2c) could not be found in the repository"
>
> What is the best way to submit this diff given that the repository does not yet have
this file?
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: Krishna Sadasivam
> Sent: Friday, August 10, 2012 10:53 AM
> To: Chip Childers; cloudstack-dev@incubator.apache.org
> Subject: RE: Review Request: Plugin for enabling Brocade as external load balancing service
provider in CloudStack
>
> I will try using org.apache.commons.codec.binary.Base64 and submit a patch.
>
> Thanks,
> Krishna
>
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Friday, August 10, 2012 7:29 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Krishna Sadasivam
> Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service
provider in CloudStack
>
> Yes,
>
> Krishna, can you please use the Base64 class that's available in deps/cloud-commons-codec-1.5.jar
?
>
> org.apache.commons.codec.binary.Base64
>
> -chip
>
> On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy <Murali.Reddy@citrix.com> wrote:
>> On 09/08/12 5:01 AM, "Krishna Sadasivam" <ksadasiv@brocade.com> wrote:
>>
>>>
>>> plugins/network-elements/brocade/test/com/cloud/network/element/Base64
>>> .jav
>>> a PRE-CREATION
>>
>> Should Base64.java be of concern from ASF license perspective? I think
>> Alex removed it [1] from the repo and this patch will re-introduce if
>> it goes to 4.0.
>>
>>
>> [1]
>> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/2012
>> 08.mb
>> ox/%3cB1DF26ECC0458748AC97CECE2DA98D41012F9EB3828C@SJCPMAILBOX01.citri
>> te.ne
>> t%3e
>>
>>
>

Mime
View raw message