cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deepti dohare" <>
Subject Re: Review Request: CS-15430 Create snapshot should fail if creating snapshot results in exceeding snapshot resource limit for domain-admin or user accounts.
Date Thu, 16 Aug 2012 10:46:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 16, 2012, 10:46 a.m.)

Review request for cloudstack.


Based on review comments, changes made to check and increment resource count whenever a snapshot
is created. Verified locally for clustered management servers 


1. Before creating the snapshot, we synchronized checkResourcelimit to allow the users to
create the snapshot and increment the resource count.
2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource

This addresses bug CS-15430.

Diffs (updated)

  api/src/com/cloud/user/ 98dfc11 
  server/src/com/cloud/resourcelimit/ b285d2c 
  server/src/com/cloud/storage/snapshot/ 6e3f9c1 



Steps to verify:
1.Login as admin, set snapshot limit '3' for a user account
2.login as user, create a VM1 with data volume
3.trigger 3 create snapshot command from the above data volume, succeeded
4.create one more snapshot, failed, "maximum limit exceeded for account user"


deepti dohare

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message