cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Garg" <deepakgarg.i...@gmail.com>
Subject Review Request: CS-15744 Incorrect Error Message with Disable AutoScaleVmGroup operation
Date Wed, 01 Aug 2012 12:18:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6278/
-----------------------------------------------------------

Review request for cloudstack, Murali Reddy, Pranav Saxena, and Vijay Venkatachalam.


Description
-------

CS-15744
Incorrect Error Message with Disable AutoScaleVmGroup operation

Platform : 

MS : Cent OS 6.2 64 bit , KVM host - RHEL 6.2 64 bit , Advanced Networking Zone , Netscaler
is 10 with build as 54.161 . 

Steps : 

1. Create AutoScaleVmGroup using an API call @ http://10.102.125.218:8096/client/api?command=createAutoScaleVmGroup&lbruleid=2&minMembers=0&maxMembers=2&vmprofileid=1&scaleuppolicyids=2&scaledownpolicyids=4


By default AutoScaleVmGroup status is with enabled status 

2. Disable AutoScaleVmGroup using API call : http://10.102.125.218:8096/client/api?command=disableAutoScaleVmGroup&id=1


Now AutoScaleVmGroup status is changed to disabled 

3. Again Tried to disable using same API : 
http://10.102.125.218:8096/client/api?command=disableAutoScaleVmGroup&id=1 

Response is : 

<jobresult><errorcode>431</errorcode><errortext>Only a AutoScale Vm
Group which is in Disabled state can be disabled.</errortext></jobresult> 

It is to be modified as "Only a AutoScale Vm Group which is in enabled state can be disabled"


This addresses bug CS-15774.


Diffs
-----

  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 6f81e28 

Diff: https://reviews.apache.org/r/6278/diff/


Testing
-------

verified on my setup !


Thanks,

Deepak Garg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message