Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of runseb@gmail.com designates
 209.85.213.47 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: non-committer workflow
From: sebgoa <runseb@gmail.com>
In-Reply-To: <501841DE.3000008@widodh.nl>
Date: Tue, 31 Jul 2012 17:05:54 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <96CD3CC7-C796-4892-90DB-381077D2949E@gmail.com>
References: <59EF914C-AFDA-4C3F-9F76-3B92F0459E12@gmail.com>
 <501841DE.3000008@widodh.nl>
To: cloudstack-dev@incubator.apache.org


On Jul 31, 2012, at 4:36 PM, Wido den Hollander wrote:

> On 07/31/2012 10:24 PM, sebgoa wrote:
>> Hi,
>>=20
>> Since I am new to Cloudstack and Apache like projects, I was looking =
at the process for submitting a very small patch (e.g typo, one-liner, =
license header)
>=20
> Always welcome!
>=20
>>=20
>> The wiki page on how to use git o contribute to Cloudstack has a =
section for non-committer:
>>=20
>> =
http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+world=
#Gitworkflowinthebravenewworld-Non-committerworkflow
>>=20
>> This is a bit confusing to me, so I would like to get some feedback =
from the more seasoned developper and committers:
>>=20
>> 1-Does every patch needs to be submitted in response to a filed bug ?
>=20
> No, I don't think it needs to. If it's a trivial typo fix it's not =
needed.
>=20
>> 2-Do we got through https://reviews.apache.org ?

So Non-committers don't need to get an account on RB and submit patches =
via that path ?

>> 3-The wiki mentions sending the patch to dev mailing list with =
subject [PATCH] but that's not what I have seen in the last few weeks ?
>=20
> Committers don't need to sent their patches over the dev mailinglist. =
We haven't seen much external code lately.
>=20
>> 4-What's the best way to use git to prepare a small patch (e.g docs =
typo, one-liner ...etc), do we really need to create a branch ? how does =
it get resolved locally once the patch is accepted ?
>=20
> Yes, you still have to branch. The commands:
>=20
> $ git clone =
https://git-wip-us.apache.org/repos/asf/incubator-cloudstack.git
> $ git checkout -b typo-fix
> $ vi/nano/vim <file to fix>
> $ git commit <file to fix>
> $ git format-patch -s master
> $ git send-email newly-generated-patch-0001.patch
>=20
> Somebody with commit access will pick up that patch and apply if it's =
acceptable.
>=20
> Wido
>=20
>>=20
>> It would be nice to agree on a clear worfklow for non-committers (and =
newbies like me) so we can get some people in the mix and graduate to =
committers...
>>=20
>> Thoughts anyone ?
>>=20
>> Thanks,
>>=20
>> -Sebastien Goasguen
>> Apache Cloudstack Evangelist
>> https://sites.google.com/site/runseb/
>>=20
>>=20