Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2BE9D993E for ; Mon, 30 Jul 2012 17:03:11 +0000 (UTC) Received: (qmail 22756 invoked by uid 500); 30 Jul 2012 17:03:10 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 22734 invoked by uid 500); 30 Jul 2012 17:03:10 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 22718 invoked by uid 99); 30 Jul 2012 17:03:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2012 17:03:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0671D1C18BA; Mon, 30 Jul 2012 17:03:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7032917103674903039==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15313 - UI: Incorrect result when failed editing Account's name From: "John Kinsella" To: "Jessica Wang" , "Brian Federle" Cc: "cloudstack" , "Pranav Saxena" , "John Kinsella" Date: Mon, 30 Jul 2012 17:03:10 -0000 Message-ID: <20120730170310.22301.38205@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Kinsella" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/5661/ X-Sender: "John Kinsella" References: <20120629114947.10292.74038@reviews.apache.org> In-Reply-To: <20120629114947.10292.74038@reviews.apache.org> Reply-To: "John Kinsella" --===============7032917103674903039== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5661/#review9601 ----------------------------------------------------------- Pranav: Can you close this request as 'submitted'? - John Kinsella On June 29, 2012, 11:49 a.m., Pranav Saxena wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5661/ > ----------------------------------------------------------- > = > (Updated June 29, 2012, 11:49 a.m.) > = > = > Review request for cloudstack, Brian Federle and Jessica Wang. > = > = > Description > ------- > = > When editing the account's name , and supplying a duplicate account name = results in a successful notification along with the error message being dis= played. So i have added error handling mechanism to surpass the notificatio= n prompt in case there's an error in the response. > = > = > This addresses bug CS-15313. > = > = > Diffs > ----- > = > ui/scripts/accounts.js 16a058a = > = > Diff: https://reviews.apache.org/r/5661/diff/ > = > = > Testing > ------- > = > Verified on my own cloudstack set up. > = > = > Thanks, > = > Pranav Saxena > = > --===============7032917103674903039==--