Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B3535D997 for ; Wed, 11 Jul 2012 22:28:26 +0000 (UTC) Received: (qmail 42511 invoked by uid 500); 11 Jul 2012 22:28:26 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 42450 invoked by uid 500); 11 Jul 2012 22:28:26 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 42440 invoked by uid 99); 11 Jul 2012 22:28:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2012 22:28:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 215A81C0C1E; Wed, 11 Jul 2012 22:28:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7980219600956396001==" MIME-Version: 1.0 Subject: Re: Review Request: Modifying filter support in 3 EC2 Describe* API's(DescribeInstances, DescribeVolumes and DescribeSnapshots) to include tags. Component: AWSAPI. From: "Prachi Damle" To: "Prachi Damle" Cc: "cloudstack" , "Likitha Shetty" Date: Wed, 11 Jul 2012 22:28:26 -0000 Message-ID: <20120711222826.22238.78278@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prachi Damle" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/5909/ X-Sender: "Prachi Damle" References: <20120711132040.22238.94786@reviews.apache.org> In-Reply-To: <20120711132040.22238.94786@reviews.apache.org> Reply-To: "Prachi Damle" --===============7980219600956396001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5909/#review9099 ----------------------------------------------------------- 1) Implementation for filters tag-key and tag-value are good. 2) But the filter tag:key need not be applied on top of the CloudStack list= command's response like other filters. CloudStack List API has been update= d to accept tag key:value filter. So we can set the key and value provided = in the EC2 tag:key=3Dvalue filter to the CloudStack API and get filtered re= sults from CS. = When EC2 filter is tag:region=3Dcanada, CloudStack command should be set th= is way: http://localhost:8096/?command=3DlistVolumes&listAll=3Dtrue&tags[0].key=3Dr= egion&tags[0].value=3Dcanada - Prachi Damle On July 11, 2012, 1:20 p.m., Likitha Shetty wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5909/ > ----------------------------------------------------------- > = > (Updated July 11, 2012, 1:20 p.m.) > = > = > Review request for cloudstack and Prachi Damle. > = > = > Description > ------- > = > Tags support has been added to 3 EC2Describe* API's(DescribeInstances, De= scribeVolumes and DescribeSnapshots). Hence for the same 3 EC2Describe* API= 's filter support has been modified to included 3 tag related filters: tag-= key, tag-value and tag:key. > = > = > Diffs > ----- > = > awsapi/src/com/cloud/bridge/service/core/ec2/EC2InstanceFilterSet.java = 6d5255a = > awsapi/src/com/cloud/bridge/service/core/ec2/EC2SnapshotFilterSet.java = 1c428f0 = > awsapi/src/com/cloud/bridge/service/core/ec2/EC2VolumeFilterSet.java 95= d306f = > = > Diff: https://reviews.apache.org/r/5909/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Likitha Shetty > = > --===============7980219600956396001==--