Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38389D1C8 for ; Thu, 5 Jul 2012 04:11:24 +0000 (UTC) Received: (qmail 22527 invoked by uid 500); 5 Jul 2012 04:11:24 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 22484 invoked by uid 500); 5 Jul 2012 04:11:23 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 22460 invoked by uid 99); 5 Jul 2012 04:11:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jul 2012 04:11:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A84591C0400; Thu, 5 Jul 2012 04:11:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5754362792943046597==" MIME-Version: 1.0 Subject: Re: Review Request: CS-13376:Vm is stuck in Stopping state when MS is rebooted after the stop command was issued but answer wasn't recieved from the backend yet From: "Koushik Das" To: "Abhinandan Prateek" Cc: "cloudstack" , "Koushik Das" , "Pranav Saxena" Date: Thu, 05 Jul 2012 04:11:22 -0000 Message-ID: <20120705041122.1165.17238@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Koushik Das" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/5762/ X-Sender: "Koushik Das" References: <20120704182734.1164.55158@reviews.apache.org> In-Reply-To: <20120704182734.1164.55158@reviews.apache.org> Reply-To: "Koushik Das" --===============5754362792943046597== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5762/#review8877 ----------------------------------------------------------- The 'else' condition checks for (info =3D=3D null) but info is getting used= inside the block. This will result NP exception. - Koushik Das On July 4, 2012, 6:27 p.m., Pranav Saxena wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5762/ > ----------------------------------------------------------- > = > (Updated July 4, 2012, 6:27 p.m.) > = > = > Review request for cloudstack and Abhinandan Prateek. > = > = > Description > ------- > = > = > 1) Have just 1 xen host. > 2) Have user VMs running on the backend. > 3) Issue Stop command and allow it to reach the backend but stop MS befor= e answer comes back > 4) start the management server. > = > VM is stuck in Stopping state after restarting the management server = > = > = > This addresses bug CS-13376. > = > = > Diffs > ----- > = > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 561e5b290c8bf5e9= e319e3588535041426530c5f = > = > Diff: https://reviews.apache.org/r/5762/diff/ > = > = > Testing > ------- > = > Debugged the code by putting system.exit statements to track the response= from the backend and thereby tested it on my local cloudstack set up. > = > = > Thanks, > = > Pranav Saxena > = > --===============5754362792943046597==--