Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69884C035 for ; Mon, 2 Jul 2012 21:45:42 +0000 (UTC) Received: (qmail 95393 invoked by uid 500); 2 Jul 2012 21:45:42 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 95371 invoked by uid 500); 2 Jul 2012 21:45:42 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 95349 invoked by uid 99); 2 Jul 2012 21:45:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2012 21:45:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 56A7D1C0246; Mon, 2 Jul 2012 21:45:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4433674818096674403==" MIME-Version: 1.0 Subject: Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when creating guest IP ranges with deployDataCenter.py From: "Sheng Yang" To: "cloudstack" , "Jason Bausewein" , "Sheng Yang" Date: Mon, 02 Jul 2012 21:45:37 -0000 Message-ID: <20120702214537.6558.33698@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sheng Yang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/5678/ X-Sender: "Sheng Yang" References: <20120629235949.10292.91087@reviews.apache.org> In-Reply-To: <20120629235949.10292.91087@reviews.apache.org> Reply-To: "Sheng Yang" --===============4433674818096674403== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5678/#review8816 ----------------------------------------------------------- Ship it! Ship It! - Sheng Yang On June 29, 2012, 11:59 p.m., Jason Bausewein wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5678/ > ----------------------------------------------------------- > = > (Updated June 29, 2012, 11:59 p.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > When creating a basic network configuration with tools/marvin/marvin/depl= oyDataCenter.py, the command to create the guest ip ranges will fail. > = > 2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:= null) Exception while executing CreateVlanIpRangeCmd: > java.lang.NullPointerException > at com.cloud.configuration.ConfigurationManagerImpl.createVlanAnd= PublicIpRange(ConfigurationManagerImpl.java:2144) > at com.cloud.utils.component.ComponentLocator$InterceptorDispatch= er.intercept(ComponentLocator.java:1189) > at com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlan= IpRangeCmd.java:164) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilt= er(ApplicationFilterChain.java:290) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(Appli= cationFilterChain.java:206) > at org.apache.catalina.core.StandardWrapperValve.invoke(StandardW= rapperValve.java:233) > at org.apache.catalina.core.StandardContextValve.invoke(StandardC= ontextValve.java:191) > at org.apache.catalina.core.StandardHostValve.invoke(StandardHost= Valve.java:127) > at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReport= Valve.java:102) > at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValv= e.java:555) > at org.apache.catalina.core.StandardEngineValve.invoke(StandardEn= gineValve.java:109) > at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdap= ter.java:298) > at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioP= rocessor.java:886) > at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHan= dler.process(Http11NioProtocol.java:721) > at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(Nio= Endpoint.java:2256) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolEx= ecutor.java:1110) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolE= xecutor.java:603) > at java.lang.Thread.run(Thread.java:679) > = > When using basic networking and not specifying the network, the code need= s to fetch the network as well. > = > = > Diffs > ----- > = > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916= e = > = > Diff: https://reviews.apache.org/r/5678/diff/ > = > = > Testing > ------- > = > Guest IP ranges are created correctly after this change. > = > = > Thanks, > = > Jason Bausewein > = > --===============4433674818096674403==--