cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Soundararajan <pradeep.soundarara...@citrix.com>
Subject RE: Review Request: [Defect / Enhancement / New Feature] CS-15281 : Removal of third party dependencies in Citrix code base
Date Wed, 04 Jul 2012 17:55:38 GMT
Yes, I have executed the below successfully:

ant build-all
package marvin

Thanks,
Pradeep.S

From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of David Nalley
Sent: Wednesday, July 04, 2012 11:19 PM
To: cloudstack; David Nalley; Pradeep Soundararajan
Subject: Re: Review Request: [Defect / Enhancement / New Feature] CS-15281 : Removal of third
party dependencies in Citrix code base

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5740/




This removes paramiko itself but there are still 'dependencies' on paramiko in the code.



Marvin uses this - so after you've removed paramiko does Marvin still work?

Prasanna: any thoughts on the above



Also tools/migration/upgrade.py uses it. If as edison points out, that is deprecated we should
remove it, not just leave vestiges hanging around.

client/bindir/update-xenserver-licenses.in also makes use of paramiko.



Finally - there's a dependency on paramiko in the spec file for -client. Is that really needed
or not? If not remove it from the spec file as well.



--David


- David


On July 4th, 2012, 8:20 a.m., Pradeep Soundararajan wrote:
Review request for cloudstack.
By Pradeep Soundararajan.

Updated July 4, 2012, 8:20 a.m.

Description

[Defect / Enhancement / New Feature] CS-15281 : Removal of third party dependencies in Citrix
code base



[Problem]

CloudStack uses a significant amount of third party software.  As part of the move to ASF
there is a certain set of licenses that are compatible with ASF policy.  We need to make sure
that every dependency we have is in that set. If it's not we have to remove it.



[Solution]

Second set: Removing Paramiko



[Reviewers]

None



[Testing]

    [Test Cases]

        Executed ANT build-all and pacakge marvin sucessfully after removing Paramiko from
tool/migration.



    [Platform]

        Fedora



Signed-off-by: Pradeep <pradeep.soundararajan@citrix.com<mailto:pradeep.soundararajan@citrix.com>>


Testing

Executed ANT build-all and pacakge marvin sucessfully after removing Paramiko from tool/migration.


Diffs

 *   tools/migration/paramiko/__init__.py (f560cc3c2d7fb9e8e0e97a39e82581a97f4f5c95)
 *   tools/migration/paramiko/agent.py (d953d3974c0a58b6ece891640070fde04a73b69b)
 *   tools/migration/paramiko/auth_handler.py (41cb1f8bb76581ab46dc74aeec7e273467f8c02a)
 *   tools/migration/paramiko/ber.py (326512732b9b66e1a00a4917758154e9c1577419)
 *   tools/migration/paramiko/buffered_pipe.py (4bd4856c2d179d8815283d8a70d09b05aa30f52a)
 *   tools/migration/paramiko/channel.py (d30496cf1dd44ab33afe35e0da804d22744cdbd0)
 *   tools/migration/paramiko/client.py (b9fe5464670f8a0174452b038bdc9f22187154d1)
 *   tools/migration/paramiko/common.py (9b4be504fc5ebbf0d80d9ce8f8cb313c5779afc6)
 *   tools/migration/paramiko/compress.py (6e61715a5e3a0ad3099d95bc89e5a9f1a2d27c2b)
 *   tools/migration/paramiko/config.py (93161c875bfb1e3f4e1d039d1816d452f6cbbe47)
 *   tools/migration/paramiko/dsskey.py (c693df960ba29d3afb2736890fc30494d2a891a7)
 *   tools/migration/paramiko/file.py (ac86437c0e56c541b9a3ce6365de671fc64e52ce)
 *   tools/migration/paramiko/hostkeys.py (0786cdabf08203059e85fd070dd32afcd9e030c1)
 *   tools/migration/paramiko/kex_gex.py (2aebcd29ae1788c3667ed59d94b462ace7d05ab7)
 *   tools/migration/paramiko/kex_group1.py (5922939bc1f3b910ae5201f24112aeef88ca4096)
 *   tools/migration/paramiko/logging22.py (9b9c142d1b5dcf93e707fbb780ed95ee190c67d0)
 *   tools/migration/paramiko/message.py (d6a8e572f3d707181c7fadae81e2701ed3125f72)
 *   tools/migration/paramiko/packet.py (899ba57a031920d9094d3ed4e83574099ed1fbbd)
 *   tools/migration/paramiko/pipe.py (9be8ca9be23c49131d701cb0db09018562279aee)
 *   tools/migration/paramiko/pkey.py (58e6686e1adc4b7c6714098011e73e38615bc73e)
 *   tools/migration/paramiko/primes.py (0c12732289dafb92e426ad4ed2d4f3e9f25ea0fc)
 *   tools/migration/paramiko/resource.py (e8d35fd6e094479ff617b389238147e05982aa22)
 *   tools/migration/paramiko/rng.py (fdfaa5e4fa179e2ef95c68d37c0a69855b5900e1)
 *   tools/migration/paramiko/rng_posix.py (f1389504d4cd166da5ec2ef012b81e53fae22019)
 *   tools/migration/paramiko/rng_win32.py (8065e94ae7b2caf8c974c5b5230da58b4d6a52dd)
 *   tools/migration/paramiko/rsakey.py (160ad692afa618c3e4e3f331b0560b456077b5a9)
 *   tools/migration/paramiko/server.py (67147f6c3b35eea69075e2cea4459838adc0ced8)
 *   tools/migration/paramiko/sftp.py (0ed67965cd70a8d0ce75ad37e958240edcd0fde4)
 *   tools/migration/paramiko/sftp_attr.py (731386f344fe9b24b0173a6da215f02324874a7f)
 *   tools/migration/paramiko/sftp_client.py (520685997c0e5e183fd24f615b2491c7ca292f01)
 *   tools/migration/paramiko/sftp_file.py (5f4e5395b7214b2fff6606e5be590a5d663941c5)
 *   tools/migration/paramiko/sftp_handle.py (0576eeb1a3f18bb5427389307fd9a3cb1ec57ae1)
 *   tools/migration/paramiko/sftp_server.py (db6fa27f23e3b72f6b536c1987cae84c49f5c8f6)
 *   tools/migration/paramiko/sftp_si.py (1d52a17fec8efa399dc0034317fa39821b8e035f)
 *   tools/migration/paramiko/ssh_exception.py (b813e60afd1c49b9ce5f95b65ab69b90ae96522b)
 *   tools/migration/paramiko/transport.py (a7251f61e8bde949aeb0eefca9dfc2d89ae4175f)
 *   tools/migration/paramiko/util.py (7cc2e2552a82906dcc10d9484290d950b7324ab2)
 *   tools/migration/paramiko/win_pageant.py (2e8b51bc503dd080ee314ad5060f19d574efa513)

View Diff<https://reviews.apache.org/r/5740/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message