cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request: CS-12707: UI/API - templates> select view: ISOs filter by: featured or mine> provides unending pages of 2 ISO entries, DB contains only 19 ISO entries.
Date Tue, 24 Jul 2012 17:28:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5930/
-----------------------------------------------------------

(Updated July 24, 2012, 5:28 p.m.)


Review request for cloudstack and Alena Prokharchyk.


Changes
-------

Removed hard coded search parameter for ISOs.


Description
-------

Changes done: Added the restriction on listing ISOs by not allowing total no. of ISOs on a
page to exceed the page size.
Made a check on the total public ISOs on a page not to repeat infinetly.


This addresses bug CS-12707.


Diffs (updated)
-----

  server/src/com/cloud/storage/dao/VMTemplateDao.java ed80aae 
  server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 1db12aa 

Diff: https://reviews.apache.org/r/5930/diff/


Testing
-------

Verified the fix from both UI and API calls.UI does not show repeating ISOs and API does not
list any ISOs for a invalid page request-parameter.


Thanks,

Saksham Srivastava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message