cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "disheng su" <edison...@citrix.com>
Subject Re: Review Request: Fix deployDataCenter.py to allow creating basic zone with or without security groups
Date Tue, 03 Jul 2012 19:58:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5726/#review8853
-----------------------------------------------------------

Ship it!


Applied, thanks for your patch.

- disheng su


On July 3, 2012, 7:20 p.m., Jason Bausewein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5726/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 7:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Fixed deployDataCenter.py to select the correct network offering based on if security
groups are enabled.  Also added default value to configGenerator.py for basic setup.
> 
> 
> This addresses bug none.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/configGenerator.py 1e84f90 
>   tools/marvin/marvin/deployDataCenter.py 5c7880e 
> 
> Diff: https://reviews.apache.org/r/5726/diff/
> 
> 
> Testing
> -------
> 
> Created basic setup with and without security groups enabled.
> 
> 
> Thanks,
> 
> Jason Bausewein
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message