cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Federle" <brian.fede...@citrix.com>
Subject Re: Review Request: CS-15313 - UI: Incorrect result when failed editing Account's name
Date Mon, 02 Jul 2012 18:02:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5661/#review8808
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Federle


On June 29, 2012, 11:49 a.m., Pranav Saxena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5661/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 11:49 a.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Description
> -------
> 
> When editing the account's name , and supplying a duplicate account name results in a
successful notification along with the error message being displayed. So i have added error
handling mechanism to surpass the notification prompt in case there's an error in the response.
> 
> 
> This addresses bug CS-15313.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/accounts.js 16a058a 
> 
> Diff: https://reviews.apache.org/r/5661/diff/
> 
> 
> Testing
> -------
> 
> Verified on my own cloudstack set up.
> 
> 
> Thanks,
> 
> Pranav Saxena
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message