Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 540F2C864 for ; Tue, 5 Jun 2012 16:45:30 +0000 (UTC) Received: (qmail 49255 invoked by uid 500); 5 Jun 2012 16:45:30 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 49205 invoked by uid 500); 5 Jun 2012 16:45:30 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 49196 invoked by uid 99); 5 Jun 2012 16:45:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2012 16:45:30 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of srivatsav.prasanna@gmail.com designates 209.85.214.175 as permitted sender) Received: from [209.85.214.175] (HELO mail-ob0-f175.google.com) (209.85.214.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2012 16:45:24 +0000 Received: by obhx4 with SMTP id x4so10518516obh.6 for ; Tue, 05 Jun 2012 09:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Los3aQnYe08TfZZSUaFr6+fpZizOH0Y5ykOt2mQ7Aus=; b=T2eycAlHu4gO76hMrOYp0a8fHFuykl7ZpN4FzLkbBcjTtcK8FaI0gk31HZmBKz3c/s tytRqFOEaoDeaN6HhLdMmgui1+tnYG5oDW5+yLFE5hhW5LkqPR3Gyf4njOpa5n4+XZQc 8oD0VHwnc3BPA6EjN3nCpMd2xalmuS26yWSvh53Ye1wbXEABKAuOxoRQ10xbV6uWt7vR 1fouEVUiOWFjUnnOBoTUBRc91u3EKQQqBYy/brZLlO9gqCXVkCbLHc//P4Nk1vWbQ0uc npI2ESRgy+yO6sjLyt5zI4pQ6jDp36acGKhfp2ouuoW9PsZvxlhsw31NqX7d2bUDrAVE TQ3g== MIME-Version: 1.0 Received: by 10.182.16.102 with SMTP id f6mr17072738obd.48.1338914703011; Tue, 05 Jun 2012 09:45:03 -0700 (PDT) Received: by 10.76.120.100 with HTTP; Tue, 5 Jun 2012 09:45:02 -0700 (PDT) In-Reply-To: References: <20120605103811.GA31569@cloud.com> Date: Tue, 5 Jun 2012 22:15:02 +0530 Message-ID: Subject: Re: [PATCH] Adding support for file copy to marvin's remoteSSHClient From: prasanna To: cloudstack-dev@incubator.apache.org Content-Type: text/plain; charset=UTF-8 >> This inherently looks ok, but Paramiko that you use in the above patch >> is licensed LGPLv2 - and needs to be removed[1]. Before we perpetuate >> its use, would you take a look at: >> >> http://bugs.cloudstack.org/browse/CS-14998 >> http://bugs.cloudstack.org/browse/CS-14999 >> http://bugs.cloudstack.org/browse/CS-15001 >> http://bugs.cloudstack.org/browse/CS-15002 >> >> Since FWIU, the test client is the only place python-paramiko is >> currently used it should be simple to eradicate that and just add a >> dependency in the RPM/deb (or egg). > > Test client doesn't include the paramkio source code into its directory, the migration tool(tools/migration) does. > Thanks David for keeping a tight watch. We egg-ified the test client just before the move to ASF. [1] The python egg for marvin (test framework) does not package the paramiko library [2]. It only enforces it as a dependency for running the marvin test client. So I think we are okay. Also as Edison says we didn't package the library into our code base. Having said that - we do have some duplicate code lying around after the packaging of marvin. I will send in a separate patch for removing the duplicate code in tools/testClient. [1] http://bugs.cloudstack.org/browse/CS-14025 [2] Marvin packaging script: tools/marvin/setup.py -- Prasanna.,