Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of Edison.su@citrix.com
 designates 66.165.176.63 as permitted sender)
From: Edison Su <Edison.su@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>
Date: Fri, 15 Jun 2012 10:08:16 -0700
Subject: RE: Moving third party dependencies to ASF approved licenses -
 jnetpcap
Thread-Topic: Moving third party dependencies to ASF approved licenses -
 jnetpcap
Thread-Index: Ac1K+22WHt2s4FFhRY+KH5rZ+dwMagAHO98A
Message-ID: 
 <C66C814C1ABFA8449FF65CB44953A8B4012CB890BC94@SJCPMAILBOX01.citrite.net>
References: 
 <35F04D4C394874409D9BE4BF45AC5EA9FED4F2586F@BANPMAILBOX01.citrite.net>
 <CAKprHVYhB6erkXaMc_Vh3p8JBJb7BjBOTK0SkQ5Dt=OHzSkw=g@mail.gmail.com>
In-Reply-To: 
 <CAKprHVYhB6erkXaMc_Vh3p8JBJb7BjBOTK0SkQ5Dt=OHzSkw=g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0


> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Friday, June 15, 2012 6:32 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Moving third party dependencies to ASF approved licenses -
> jnetpcap
>=20
> On Fri, Jun 15, 2012 at 1:58 AM, Pradeep Soundararajan
> <pradeep.soundararajan@citrix.com> wrote:
> > CloudStack uses a significant amount of third party software. =A0As
> part of the move to ASF there is a certain set of licenses that are
> compatible with ASF policy. =A0We need to make sure that every dependency
> we have is in that set. =A0If it's not we have to remove it.
> >
> > As part of this initiative we are in the process of removing third
> party dependencies from Citrix code base. We have listed JnetPcap
> package is one among that and it is a part of LGPLv3 (license). So we
> are planning to remove the same from our source code.
> >
> > I have checked out my private branch from ASF master to perform this
> task.
> >
> > I have noticed, that we are importing the classes of 'jnetpcap' in
> these java files:
> >
> > DhcpSnooperImpl.java
> > DhcpPacketParser.java
> > HttpTemplateDownloader.java
> >
> > I am not seeing this has been used extensively in
> "HttpTemplateDownloader.java" except for the import section. So I have
> removed it very easily. =A0But for the other two, I have noticed, many
> other classes of jnetpcap have been used in different places.
> >
> > For an example in DhcpSnooperImpl.java:
> >
> > import org.jnetpcap.Pcap;
> > import org.jnetpcap.PcapBpfProgram;
> > import org.jnetpcap.PcapIf;
> > import org.jnetpcap.packet.PcapPacket;
> > import org.jnetpcap.packet.PcapPacketHandler;
> > import org.jnetpcap.protocol.tcpip.Udp;
> > .........................
> > .........................
> > .........................
> > PcapBpfProgram program =3D new PcapBpfProgram();
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 String expr =3D "ds=
t port 68 or 67";
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 int optimize =3D 0;
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 int netmask =3D 0xF=
FFFFF00;
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (pcap.compile(pr=
ogram, expr, optimize,
> netmask) !=3D Pcap.OK) {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0s_lo=
gger.debug("Pcap: can't compile
> BPF");
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0retu=
rn null;
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
> > ...................................
> > So on..........
> > .................................
> >
> > Also, I have noticed "DhcpListener"
> in =A0"DhcpProtocolParserServer.java" and "DhcpSnooperImpl.java". Could
> anyone please elaborate how do you say "DhcpListener" =A0is deprecated?
> What would you mean by that?. =A0I was thinking it is a separate java
> file, we have to remove it but it seems to be my understanding is
> incorrect.
> >
> > I was trying to execute a build for each and every changes but facing
> some Java compilation issues most of the time. Could anyone let me know
> how to remove these dependencies from all the files and how to overcome
> this issue?
> >
> > I am planning to send a patch to ASF once I am done with the final
> validation for "JnetPcap"...
> >
> > Thanks,
> > Pradeep.S
> >
> >
> >
> >
> >
>=20
> Pradeep:
>=20
> Thanks for starting this work, I know it is less than fun.
>=20
> WRT to DhcpListener, see this message from Edison who notes that is
> deprecated.
> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-
> dev/201206.mbox/%3CC66C814C1ABFA8449FF65CB44953A8B4012CB890BC8B%40SJCPM
> AILBOX01.citrite.net%3E
>=20
> I assume that means the entire idea of listening on the wire for a
> DHCP response is deprecated, which should mean the other two are as
> well. Edison, care to comment?

Yah, it tries to get IP address of User VM by snooping the bridge. It's use=
d by the project for other purpose, and don't use it anymore... It's ok the=
 remove this java files.

>=20
> --David