cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kinsella <...@stratosec.co>
Subject Re: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)
Date Thu, 17 May 2012 16:42:52 GMT
I'd like to document the process for Apache CloudStack, as well...for this one I sent a pull
request to CloudStack on github, but I suspect that process is going to change in the coming
weeks...

John

On May 17, 2012, at 9:38 AM, Edison Su wrote:

> Thanks for the fix, looks good to me. 
> David, If I want to pull this patch into cloudstack, do I just do it? 
> 
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: Wednesday, May 16, 2012 9:24 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Fwd: [PATCH] CS-14955: security_group.py only creates ICMP
>> iptables rules for ICMP type -1 (#10)
>> 
>> ---------- Forwarded message ----------
>> From: John Kinsella
>> <reply+i-4618094-5076ad5f2a6de057314b343bf37e89569aadf6c7-
>> 1129409@reply.github.com>
>> Date: Wed, May 16, 2012 at 10:54 PM
>> Subject: [CloudStack] CS-14955: security_group.py only creates ICMP
>> iptables rules for ICMP type -1 (#10)
>> To:
>> 
>> 
>> Description:
>> Unindented 3 lines to update logic flow to execute iptables when
>> passed ICMP type is not -1.
>> 
>> You can merge this Pull Request by running:
>> 
>>  git pull https://github.com/jlk/CloudStack master
>> 
>> Or you can view, comment on it, or merge it online at:
>> 
>>  https://github.com/CloudStack/CloudStack/pull/10
>> 
>> -- Commit Summary --
>> 
>> * CS-14955: security_group.py only creates ICMP iptables rules for
>> 
>> -- File Changes --
>> 
>> M scripts/vm/network/security_group.py (6)
>> 
>> -- Patch Links --
>> 
>>  https://github.com/CloudStack/CloudStack/pull/10.patch
>>  https://github.com/CloudStack/CloudStack/pull/10.diff
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/CloudStack/CloudStack/pull/10



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message