cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] ggoodrich-ipp opened a new pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
Date Wed, 15 Apr 2020 19:12:19 GMT
ggoodrich-ipp opened a new pull request #4032: Suspending the VM prior to deleting snapshots
to avoid corruption, th…
URL: https://github.com/apache/cloudstack/pull/4032
 
 
   …en resuming
   
   ## Description
   <!--- Describe your changes in detail -->
   These changes are related to PR #3194, but include suspending/resuming the VM when doing
a VM snapshot as well, when deleting a VM snapshot, as it is performing the same operations
via Libvirt. Also, there was an issue with the UI/localization changes in the prior PR, as
that PR was altering the Volume snapshot behavior, but was altering the VM snapshot wording.
Both have been altered in this PR.
   
   Issuing this in response to the work happening in PR #4029.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed
when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message