From commits-return-96952-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Jan 9 04:15:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D2B8A180607 for ; Thu, 9 Jan 2020 05:15:08 +0100 (CET) Received: (qmail 91321 invoked by uid 500); 9 Jan 2020 04:15:08 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 91312 invoked by uid 99); 9 Jan 2020 04:15:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jan 2020 04:15:08 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] rhtyd commented on a change in pull request #3601: [WIP] JDK11 support Message-ID: <157854330794.7883.13213107369529678032.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 09 Jan 2020 04:15:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rhtyd commented on a change in pull request #3601: [WIP] JDK11 support URL: https://github.com/apache/cloudstack/pull/3601#discussion_r364552918 ########## File path: server/src/test/java/com/cloud/storage/listener/StoragePoolMonitorTest.java ########## @@ -58,17 +60,18 @@ public void setUp() throws Exception { @Test public void testProcessConnectStoragePoolNormal() throws Exception { - Mockito.when(poolDao.listBy(Mockito.anyLong(), Mockito.anyLong(), Mockito.anyLong(), Mockito.any(ScopeType.class))).thenReturn(Collections.singletonList(pool)); + Mockito.when(poolDao.listBy(nullable(Long.class), nullable(Long.class), nullable(Long.class), Mockito.any(ScopeType.class))).thenReturn(Collections.singletonList(pool)); Mockito.when(poolDao.findZoneWideStoragePoolsByTags(Mockito.anyLong(), Mockito.any(String[].class))).thenReturn(Collections.emptyList()); Mockito.when(poolDao.findZoneWideStoragePoolsByHypervisor(Mockito.anyLong(), Mockito.any(Hypervisor.HypervisorType.class))).thenReturn(Collections.emptyList()); + Mockito.doNothing().when(storageManager).connectHostToSharedPool(host.getId(), pool.getId()); storagePoolMonitor.processConnect(host, cmd, false); Mockito.verify(storageManager, Mockito.times(1)).connectHostToSharedPool(Mockito.eq(host.getId()), Mockito.eq(pool.getId())); Mockito.verify(storageManager, Mockito.times(1)).createCapacityEntry(Mockito.eq(pool.getId())); } - @Test(expected = ConnectionException.class) + @Test Review comment: Yes I suppose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services