cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3681: Validate disk offering IOPS normal and maximum read/write values
Date Thu, 16 Jan 2020 09:42:03 GMT
DaanHoogland commented on a change in pull request #3681: Validate disk offering IOPS normal
and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681#discussion_r367318567
 
 

 ##########
 File path: server/src/test/java/com/cloud/configuration/ConfigurationManagerTest.java
 ##########
 @@ -166,6 +168,8 @@
 
     VlanVO vlan = new VlanVO(Vlan.VlanType.VirtualNetwork, "vlantag", "vlangateway", "vlannetmask",
1L, "iprange", 1L, 1L, null, null, null);
 
+    private static final String MAXIMUM_IOPS_ALLOWED = "3600";
 
 Review comment:
   imho: MAXIMUM_DURATION_ALLOWED

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message