cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router
Date Mon, 13 Jan 2020 17:55:20 GMT
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#discussion_r365943144
 
 

 ##########
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##########
 @@ -1174,15 +1174,14 @@
         Pair<List<DomainRouterJoinVO>, Integer> result = searchForRoutersInternal(cmd,
cmd.getId(), cmd.getRouterName(), cmd.getState(), cmd.getZoneId(), cmd.getPodId(), cmd.getClusterId(),
                 cmd.getHostId(), cmd.getKeyword(), cmd.getNetworkId(), cmd.getVpcId(), cmd.getForVpc(),
cmd.getRole(), cmd.getVersion());
         ListResponse<DomainRouterResponse> response = new ListResponse<DomainRouterResponse>();
+        if (!VirtualNetworkApplianceManager.RouterHealthChecksEnabled.value()) {
+            s_logger.debug("Skipping health checks data in router as router.health.checks.enabled
is false for router");
+            return response;
+        }
 
 Review comment:
   Daan this is a debug log and returned as per API. The extended logics are logged in method
calls. thoughtS?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message