From commits-return-95207-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Dec 3 13:27:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2CBE9180629 for ; Tue, 3 Dec 2019 14:27:57 +0100 (CET) Received: (qmail 59280 invoked by uid 500); 3 Dec 2019 13:27:56 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 59269 invoked by uid 99); 3 Dec 2019 13:27:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2019 13:27:56 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] [cloudstack] weizhouapache commented on a change in pull request #3737: Add missing HA config keys Message-ID: <157537967636.9242.13629617507766135568.gitbox@gitbox.apache.org> Date: Tue, 03 Dec 2019 13:27:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit weizhouapache commented on a change in pull request #3737: Add missing HA config keys URL: https://github.com/apache/cloudstack/pull/3737#discussion_r353174950 ########## File path: engine/components-api/src/main/java/com/cloud/ha/HighAvailabilityManager.java ########## @@ -16,18 +16,36 @@ // under the License. package com.cloud.ha; -import java.util.List; +import static java.lang.String.valueOf; import com.cloud.deploy.DeploymentPlanner; import com.cloud.host.HostVO; import com.cloud.host.Status; import com.cloud.utils.component.Manager; import com.cloud.vm.VMInstanceVO; +import org.apache.cloudstack.framework.config.ConfigKey; + +import java.util.List; /** * HighAvailabilityManager checks to make sure the VMs are running fine. */ public interface HighAvailabilityManager extends Manager { + + ConfigKey TimeBetweenCleanup = new ConfigKey<>("Advanced", Integer.class, + "time.between.cleanup", valueOf(3600 * 24), "Time in milliseconds to wait before the cleanup thread runs.", Review comment: it should be "seconds" in the description ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services